Regression : 'Tab' focus is not seen on 'Fit to page/Zoom in/out' icons in any PDF and Print Preview window.
Reported by
avsha...@etouch.net,
Oct 22
|
||||||
Issue descriptionChrome Version : 72.0.3587.0 (Official Build) ceec2bcac925277f50404b2635f219c63666a09a-refs/branch-heads/3587@{#1} 32/64 bit OS : Mac(10.13.1, 10.13.6, 10.14.1), Linux(14.04), Windows(7,8,10) Test URL : http://unec.edu.az/application/uploads/2014/12/pdf-sample.pdf What steps will reproduce the problem? 1. Launch chrome and navigate to above test URL. 2. Click inside 'Page number' text box seen on PDF toolbar and press 'Tab' key to bring focus on 'Fit to page'/'Zoom in'/'Zoom out' icons. 3. Observe. Actual Result : 'Tab' focus is not seen on 'Fit to page'/'Zoom in'/'Zoom out' icons in any PDF and print preview window. Expected Result : Grey highlight should appear when 'Tab' focus reaches 'Fit to page'/'Zoom in'/'Zoom out' icons This is a regression issue broken in M-72 and below is the bisect information: Good Build : 72.0.3583.0 (Revision : 600164) Bad Build : 72.0.3584.0 (Revision : 600616) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/62f2f8f209a82db0dd5a311eb4f844bddb75c98e..631a939b2b9a02a05cd1db367c7ea7fb17d14f50 Suspecting : r600225 ? dpapad@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Issue can be reproduced on any PDF page and Chrome Print Preview window. 2. Unable to provide bisect using 'per-revision' script as it shows "We don't have enough builds.." error message for above regression range, hence provided suspect through 'Chromium bisect'. (Tried on other machines but still getting the same error again) Thank you..!
,
Oct 23
,
Oct 24
Minimal repro examples: Shadow DOM v0: https://jsfiddle.net/opn3yhux/4/ Shadow DOM v1: https://jsfiddle.net/asv01kon/5/ @futhark: Which one is the correct one? It seems that the Shadow DOM v1 behavior is to have anything with :host() have a smaller priority, even if it is more specific (by using a CSS class)? This is causing WebUI regressions when transitioning from v0 to v1.
,
Oct 24
,
Oct 24
this may be understood / assumed by others, but i found this part of the spec on :host() specificity pretty clear: https://drafts.csswg.org/css-scoping/#host-selector """ The specificity of :host() is that of a pseudo-class, plus the specificity of its argument. """ so if :host(.class) {...} inside x-element loses to x-element {...} (from outside styling code): seems like a bug to me.
,
Oct 24
Outer scope wins over inner scope regardless of specificity. If the :host() rules should win over outer scope, they need to be !important. The relevant specification is https://drafts.csswg.org/css-scoping-1/#shadow-cascading
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6e246dfa538c181f377dbcbbf8e1d3455290d0f commit f6e246dfa538c181f377dbcbbf8e1d3455290d0f Author: rbpotter <rbpotter@chromium.org> Date: Wed Oct 24 22:15:32 2018 PDF Viewer: Use mixin instead of overriding background-color In Polymer 2, setting background-color for paper-fab directly overrides the value applied when the paper-fab has keyboard focus, as well as the normal value. paper-fab provides a mixin for setting the background color. Using this mixin sets the default background color correctly, and allows the background-color styling that overrode the styling for :host(.keyboard-focus) to be removed. Bug: 897595 Change-Id: I7332d57b822286c884ef6ca7a32d6b890130a5e3 Reviewed-on: https://chromium-review.googlesource.com/c/1297629 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602485} [modify] https://crrev.com/f6e246dfa538c181f377dbcbbf8e1d3455290d0f/chrome/browser/resources/pdf/elements/viewer-zoom-toolbar/viewer-zoom-button.html
,
Oct 24
,
Oct 25
--------- Update : --------- Verified above issue in latest Canary build #72.0.3591.0 on Mac(10.13.1, 10.13.6, 10.14.1), Linux(14.04) & Windows(7,8,10) OS and the issue is fixed. 'Tab' focus is seen properly on 'Fit to page/Zoom in out' icons and it is working as intended, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Oct 22Cc: rbpotter@chromium.org dpa...@chromium.org
Owner: ----
Status: Available (was: Assigned)