New issue
Advanced search Search tips

Issue 897594 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 896748



Sign in to add a comment

Regression : Separator line at the bottom of 'Add languages' overlay is missing in chrome://settings/languages.

Reported by rp...@etouch.net, Oct 22

Issue description

Version: 72.0.3587.0 (Official Build)Revision ceec2bcac925277f50404b2635f219c63666a09a-refs/branch-heads/3587@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.14.1,10.13.6)

What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://settings/languages and expand it.
2. Now click on 'Add Languages' overlay and observe above 'Cancel' and 'Add' buttons

Actual: Separator line at the bottom of 'Add languages' overlay is missing
Expected: Separator line at the bottom of 'Add languages' overlay should be seen

This is regression issue, broken in ‘M 72’ and below is the bisect info :
Good build: 72.0.3583.0 (Revision: 600164)
Bad build : 72.0.3584.0 (Revision: 600616)
 
You are probably looking for a change made after 600215 (known good), but no later than 600248 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  
https://chromium.googlesource.com/chromium/src/+log/c16e7e464ad15925ee652fffd9eed8f6c355b1be..363127236baaa7f536ce51f5b769f3095169789b?pretty=fuller&n=50

Suspect : r600225 ?

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Provided suspect through 'Chromium bisect' script because unable to perform bisect using 'per-revision' bisect script.
2. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.


Kindly review attached screen cast for same.

Thanks!
 
 
Actual_video.mov
1.8 MB View Download
Expected_video.mov
1.8 MB View Download
Blocking: 896748
Owner: ----
Status: Available (was: Assigned)
Owner: dpa...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c22b239be04e729e3ffc8f2180cc195cd041837

commit 9c22b239be04e729e3ffc8f2180cc195cd041837
Author: dpapad <dpapad@chromium.org>
Date: Fri Oct 26 20:04:36 2018

WebUI: Fix CrScrollableBehavior initialization with Polymer 2.

In Polymer 2, the contents of an element are not stamped until after the
ready callback, unlike Polymer 1 (because of differences within Shadow DOM
v0 and v1).

Bug:  897594 
Change-Id: I51509d5823bbffe4fba3bbf3cf7db9aec6c81e8c
Reviewed-on: https://chromium-review.googlesource.com/c/1297630
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603178}
[modify] https://crrev.com/9c22b239be04e729e3ffc8f2180cc195cd041837/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/9c22b239be04e729e3ffc8f2180cc195cd041837/chrome/test/data/webui/cr_elements/cr_scrollable_behavior_tests.js
[modify] https://crrev.com/9c22b239be04e729e3ffc8f2180cc195cd041837/ui/webui/resources/cr_elements/cr_scrollable_behavior.js

Status: Fixed (was: Started)

Sign in to add a comment