video_PowerConsumption has exception "TypeError: run_once() takes at least 4 arguments (4 given)" since R71-11151.5.0 |
||||||||
Issue descriptionDevice: all devices Regression on: R71-11151.5.0 and R72 https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?testName=video_PowerConsumption&suite=&daysBack=30&board=&architecture=&boardFamily=&buildConfig=&reason=&version=&milestone=71&dut=&token=AOheusOURyeDK-CnK2fjGDo18c4e%3A1540177357696 10/18 18:33:23.841 DEBUG| test:0381| Test failed due to run_once() takes at least 4 arguments (4 given). Exception log follows the after_iteration_hooks. 10/18 18:33:23.955 WARNI| test:0606| The test failed with the following exception Traceback (most recent call last): File "/usr/local/autotest/common_lib/test.py", line 600, in _exec _call_test_function(self.execute, *p_args, **p_dargs) File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function raise error.UnhandledTestFail(e) UnhandledTestFail: Unhandled TypeError: run_once() takes at least 4 arguments (4 given) Traceback (most recent call last): File "/usr/local/autotest/common_lib/test.py", line 800, in _call_test_function return func(*args, **dargs) File "/usr/local/autotest/common_lib/test.py", line 464, in execute postprocess_profiled_run, args, dargs) File "/usr/local/autotest/common_lib/test.py", line 371, in _call_run_once self.run_once(*args, **dargs) File "/usr/local/autotest/cros/video/helper_logger.py", line 82, in call return func(*args, **kwargs) TypeError: run_once() takes at least 4 arguments (4 given)
,
Oct 22
This issue is also observed on video_PlaybackPerf.h264.4k on Nocturne in recent builds (Note: other devices look good) https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?milestone=72&daysBack=30&testName=video_PlaybackPerf.h264.4k 10/20 10:35:08.303 INFO | server_job:0217| START 250279015-chromeos-test/chromeos6-row6-rack14-host19/video_PlaybackPerf video_PlaybackPerf timestamp=1540056716 localtime=Oct 20 10:31:56 10/20 10:35:08.304 INFO | server_job:0217| FAIL 250279015-chromeos-test/chromeos6-row6-rack14-host19/video_PlaybackPerf video_PlaybackPerf timestamp=1540056718 localtime=Oct 20 10:31:58 Unhandled TypeError: run_once() takes at least 4 arguments (4 given)
,
Oct 22
I think I find the root cause In video_PowerConsumption control file, the argument "capability" is missing https://cs.corp.google.com/android/external/autotest/server/site_tests/video_PowerConsumption/control.h264?dr&g=0 Which is defined in video_PlaybackPerf.run_once() https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/video_PlaybackPerf/video_PlaybackPerf.py?dr&g=0&l=81
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/2c9a1e8d21559554cc09480f506f659ca007780c commit 2c9a1e8d21559554cc09480f506f659ca007780c Author: Pin-chih Lin <johnylin@google.com> Date: Tue Oct 23 20:01:37 2018 video_PowerConsumption: add capability argument BUG= chromium:897563 TEST=run video_PowerConsumption.h264 on Grunt Change-Id: Idb49320b5e3d5af9dd607e17cf7ec5f1e51d4b09 Reviewed-on: https://chromium-review.googlesource.com/1293392 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Pin-chih Lin <johnylin@chromium.org> Reviewed-by: Shuo-Peng Liao <deanliao@google.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> [modify] https://crrev.com/2c9a1e8d21559554cc09480f506f659ca007780c/server/site_tests/video_PowerConsumption/control.vp8 [modify] https://crrev.com/2c9a1e8d21559554cc09480f506f659ca007780c/server/site_tests/video_PowerConsumption/control.vp9 [modify] https://crrev.com/2c9a1e8d21559554cc09480f506f659ca007780c/server/site_tests/video_PowerConsumption/control.h264
,
Oct 24
Thanks, johny. Once you confirm this, could you cherry-pick CL in c#4 to M71 too? https://stainless.corp.google.com/search?view=matrix&row=board&col=build&first_date=2018-10-18&last_date=2018-10-24&test=video_PowerConsumption&exclude_cts=false&exclude_not_run=false&exclude_non_release=false&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false
,
Oct 25
Hi kbleicher@, video_PowerConsumption goes green on R72-11187.0.0 https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/testDetails?milestone=72&daysBack=30&testName=video_WebRtcPerf c#4 requests to merge back to M71, thanks.
,
Oct 25
I assume the merge request implies verification per the call-out in #5?
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 29
kbleicher@, the test starts to pass in M72 thanks to the CL#4. Could you approve? Thanks
,
Oct 29
Approving merge to M71 Chrome OS.
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c6a6053a1cb0d24dfbe07dc688c7d4f8df1da860 commit c6a6053a1cb0d24dfbe07dc688c7d4f8df1da860 Author: Pin-chih Lin <johnylin@google.com> Date: Mon Oct 29 15:21:13 2018 video_PowerConsumption: add capability argument BUG= chromium:897563 TEST=run video_PowerConsumption.h264 on Grunt Change-Id: Idb49320b5e3d5af9dd607e17cf7ec5f1e51d4b09 Reviewed-on: https://chromium-review.googlesource.com/1293392 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Pin-chih Lin <johnylin@chromium.org> Reviewed-by: Shuo-Peng Liao <deanliao@google.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> (cherry picked from commit 2c9a1e8d21559554cc09480f506f659ca007780c) Reviewed-on: https://chromium-review.googlesource.com/c/1297877 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Tested-by: Hirokazu Honda <hiroh@chromium.org> Trybot-Ready: Hirokazu Honda <hiroh@chromium.org> [modify] https://crrev.com/c6a6053a1cb0d24dfbe07dc688c7d4f8df1da860/server/site_tests/video_PowerConsumption/control.vp8 [modify] https://crrev.com/c6a6053a1cb0d24dfbe07dc688c7d4f8df1da860/server/site_tests/video_PowerConsumption/control.vp9 [modify] https://crrev.com/c6a6053a1cb0d24dfbe07dc688c7d4f8df1da860/server/site_tests/video_PowerConsumption/control.h264
,
Oct 30
,
Nov 1
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 5
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hiroh@chromium.org
, Oct 22