CHROMEOS_LKGM updates blocked due to QEMU errors |
||||||||
Issue descriptionSee https://chromium-review.googlesource.com/c/chromium/src/+/1292931 The update causes all VM tests to fail. eg: https://chromium-swarm.appspot.com/task?id=40af54274c409e10. Looks like the failure is "qemu: could not load PC BIOS 'bios-256k.bin'". Is the latest SDK missing a qemu dependency?
,
Oct 22
,
Oct 22
to clarify on the usage, the Chromium bots are running QEMU outside of the SDK. it might be that those programs are looking at bios paths that the host distro is providing (and if they have an older install, newer files aren't there), or the bios programs aren't part of the QEMU bundle itself. i haven't debugged this failure further, just providing a bit more context.
,
Oct 24
The problem is the missing bios-256k.bin file. /usr/share/qemu has some symlinks which point to ../ipxe, ../sgabios, ../seavgabios, and ../seabios. The bios-256k.bin file didn't used to be a symlink, but now points to ../seabios/bios-256k.bin, and this is broken in our download of the qemu package.
,
Oct 24
doesn't sound like a bug in qemu. it used to bundle seabios images directly but has now switched to the standalone seabios package. so we'll prob want chrome-sdk to also pull down the seabios binpkg.
,
Oct 24
Do you know where that package resides? I'm assuming it's somewhere in this tree: https://pantheon.corp.google.com/storage/browser/chromeos-prebuilt/board/amd64-host/chroot-2018.10.19.201737/packages The source is in third_party/seabios/
,
Oct 24
Found it in sys-firmware
,
Oct 25
LKGM updates 11175, 11178, 11183, 11185, 11190, 11191 have failed so far. I'd like to land this CL in some form soonish - it still needs to make it through the CQ and get rolled into chrome...
,
Oct 29
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/761322d458eaa3e6dde21e5739accfa03884a26e commit 761322d458eaa3e6dde21e5739accfa03884a26e Author: Achuith Bhandarkar <achuith@chromium.org> Date: Tue Oct 30 08:04:59 2018 cros_chrome_sdk: Also download seabios package. * Download build manifest instead of saving qemu-version. * Generic code for downloading a prebuilt binary package. * Figure out seabios version from manifest and download it. * Fix up seabios symlinks in qemu/usr/share/. * Replace QEMU_BIN_KEY with QEMU_BIN_PATH. BUG= chromium:897540 TEST=cros chrome-sdk --debug --download-vm --board=amd64-generic --version=11178.0.0 --clear-sdk-cache Change-Id: Id244861694f99de22eaaddd74954e755aa4f21a4 Reviewed-on: https://chromium-review.googlesource.com/1297122 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/761322d458eaa3e6dde21e5739accfa03884a26e/cli/cros/cros_chrome_sdk.py [modify] https://crrev.com/761322d458eaa3e6dde21e5739accfa03884a26e/scripts/cros_vm.py
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2de9adc9a7a3d8d414dc7b5f431a5d7941848d7d commit 2de9adc9a7a3d8d414dc7b5f431a5d7941848d7d Author: Ben Pastene <bpastene@chromium.org> Date: Tue Oct 30 21:36:59 2018 Fix path to qemu dir for cros VM tests. And also roll chromite. The latest roll is blocked due to the path changing slightly: https://chromium-review.googlesource.com/c/chromium/src/+/1306765 NOTRY=true Bug: 897540 Change-Id: Idc753e8b79dcf4c231e05fb9bb6ba3ad7b52592f Reviewed-on: https://chromium-review.googlesource.com/c/1308014 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#604020} [modify] https://crrev.com/2de9adc9a7a3d8d414dc7b5f431a5d7941848d7d/DEPS [modify] https://crrev.com/2de9adc9a7a3d8d414dc7b5f431a5d7941848d7d/build/config/chromeos/rules.gni
,
Oct 30
Achuith's fix in #11 got rolled into chromium. Just pu the latest LKGM bump back in the CQ: https://chromium-review.googlesource.com/c/chromium/src/+/1303654 Let's see how it does.
,
Oct 31
Ah, the data deps need one more tweak: https://chromium-review.googlesource.com/c/chromium/src/+/1308716 *Then* it should be g2g.
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e75f5127bfd6afc81f377f9a3a16e1c4538fabe4 commit e75f5127bfd6afc81f377f9a3a16e1c4538fabe4 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Oct 31 01:28:28 2018 Add firmware/seabios dir in the cros-chrome-sdk to cros VM test data deps. Needed to pack up the bios-256k.bin file in the test isolates. The latest lkgm bumps fail w/o it: https://chromium-swarm.appspot.com/task?id=40e0280b72f15510 NOTRY=true Bug: 897540 Change-Id: If731c73a677cff02523b17599a1a50629b6ff430 Reviewed-on: https://chromium-review.googlesource.com/c/1308716 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#604096} [modify] https://crrev.com/e75f5127bfd6afc81f377f9a3a16e1c4538fabe4/build/config/chromeos/rules.gni
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0195087e4157e866fa9f34c6ce5ea7a19c026dc commit d0195087e4157e866fa9f34c6ce5ea7a19c026dc Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Wed Oct 31 02:50:35 2018 Automated Commit: LKGM 11200.0.0 for chromeos. BUG= 762641 , 897540 TBR=oshima@chromium.org Change-Id: I497be0962d522a8e3ce19ff5e09754a8c91f6a3a Reviewed-on: https://chromium-review.googlesource.com/c/1303654 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#604123} [modify] https://crrev.com/d0195087e4157e866fa9f34c6ce5ea7a19c026dc/chromeos/CHROMEOS_LKGM
,
Oct 31
hurrah, it's back to rolling: rd0195087e4157e866fa9f34c6ce5ea7a19c026dc I think we can close this out
,
Oct 31
I'll keep it open until I finish unittests
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/1c18a6ea96f7a6cc5bfcbb4bf8b789ab89a4ee23 commit 1c18a6ea96f7a6cc5bfcbb4bf8b789ab89a4ee23 Author: Achuith Bhandarkar <achuith@chromium.org> Date: Fri Nov 16 13:02:11 2018 cros_chrome_sdk_unittests: Seabios symlinks test. Check that seabios symlinks are properly created. BUG= chromium:897540 TEST=This is the test. Change-Id: I5b77a132740c9d81f0eea99525527c683fae530a Reviewed-on: https://chromium-review.googlesource.com/1338500 Commit-Ready: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/1c18a6ea96f7a6cc5bfcbb4bf8b789ab89a4ee23/cli/cros/cros_chrome_sdk_unittest.py
,
Nov 17
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by achuith@chromium.org
, Oct 21