Issue 897520 link

Starred by 2 users

Issue metadata

Status:	Assigned
Owner:	bokan@chromium.org
Components:	Blink>Scroll
EstimatedDays:	----
NextAction:	----
OS:	Linux , Android , Windows , Chrome , Mac
Pri:	3
Type:	Task

Blocked on: View detail
issue 893608
issue 902438
issue 902446
issue 915926
issue 907941

Blocking:
issue 865755
issue 869662
issue 883717
issue 905694
issue 919117
issue 919492

Make synthetic gestures reliable

Project Member Reported by bokan@chromium.org, Oct 21

Issue description

See https://docs.google.com/document/d/1B4hXTkEsvixMAB7xT1MSLlQtEEApZK5xzSMwNScQGKg/edit# for a broader description of the issues.

This bug tracks fixing the synthetic gesture system in Chrome (e.g. gpuBenchmarking.smoothScrollBy) to be more reliable. This is covers a large number of issues, from precision loss and inaccuracies to being unable to tell when a scroll is truly finished.

Comment 1 by bokan@chromium.org, Oct 21

Blocking: 883717

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f

commit 11bf6abb95700585245ad4f7f8d4f6f0b531bc1f
Author: David Bokan <bokan@chromium.org>
Date: Wed Oct 24 21:27:35 2018

Fix small scroll deltas in synthetic gestures

SyntheticGestureTargetAura::GetTouchSlopInDips was subtracting 1 from
the slop configuration value. However,
GestureDetector::IsWithinTouchSlop would incorrectly return true if we
scrolled one pixel past the slop in this case. Additionally, there's no
need to ceil the touch slop adjustment in SyntheticSmoothMoveGesture
since we're sending float deltas.

Bug: 897520
Change-Id: I35725c603910b3c694d9eddf5fde31f1f6b9cf2e
Reviewed-on: https://chromium-review.googlesource.com/c/1293171
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602458}
[modify] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/content/browser/renderer_host/input/composited_scrolling_browsertest.cc
[modify] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/content/browser/renderer_host/input/synthetic_gesture_target_aura.cc
[modify] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/content/browser/renderer_host/input/synthetic_smooth_move_gesture.cc
[modify] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/third_party/WebKit/LayoutTests/SmokeTests
[modify] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/third_party/WebKit/LayoutTests/resources/gesture-util.js
[delete] https://crrev.com/45fe99b7c3ad87279fdbc64b0d89f1b13e58bda5/third_party/WebKit/LayoutTests/synthetic_gestures/README.txt
[add] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/third_party/WebKit/LayoutTests/synthetic_gestures/animated-wheel-tiny-delta.html
[add] https://crrev.com/11bf6abb95700585245ad4f7f8d4f6f0b531bc1f/third_party/WebKit/LayoutTests/synthetic_gestures/smooth-scroll-tiny-delta.html