New issue
Advanced search Search tips

Issue 897496 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Support "a=ssrc:... msid:..." line with no stream ID

Project Member Reported by shampson@google.com, Oct 21

Issue description

Creating this bug to request a merge of a bug fix into M71.

WebRTC bug:
https://bugs.chromium.org/p/webrtc/issues/detail?id=9880

Change:
https://webrtc-review.googlesource.com/c/src/+/106757

Currently we support signaling no stream IDs by using "-" as the msid value for "a=msid:... ..." lines, but this is not supported with "a=ssrc:... msid:..." lines. What currently happens is the a=msid line will use "-" for the msid, but the a=ssrc line will use "" for the msid. Example:
a=msid:- track_id
a=ssrc:80 msid: track_id
 
Pls apply appropriate OSS label. 
Labels: OS-Android OS-Chrome OS-Fuchsia OS-iOS OS-Linux OS-Mac OS-Windows
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 22

Labels: -Merge-Request-71 Hotlist-Merge-Approved Merge-Approved-71
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M71 branch 3578 latest by 1:00 PM PT, today 10/22 so we can pick it up for next week beta release. Thank you. 
This has been merged to the M71 webrtc branch-
https://webrtc-review.googlesource.com/c/src/+/106757

As far as I'm aware I don't think I need to merge this into Chrome, if it's merged into the webrtc branch for M71. Source:
https://sites.google.com/a/google.com/rtc-platform/engineering/merging-a-webrtc-cl-to-a-chrome-branch?pli=1
Cc: tommi@chromium.org
Thank you  shampson@.

hbos@ and  tommi@, could you ptal comment #5? If it is already merged to M71, pls remove "Merge-Approved-71" label and apply  "Merge-merged-71" label. Thank you.


hbos@/tommi@, gentle ping on #6. Thank you.
Labels: -Merge-Approved-71 Merge-Merged-71
My understanding is the same as #5 ("For M41+, no change to Chromium DEPS is needed after merging a fix into the WebRTC branch."). They merged their fix in webrtc, so I think we're good.

Comment 9 Deleted

Sign in to add a comment