New issue
Advanced search Search tips

Issue 897469 link

Starred by 3 users
Status: Fixed
Owner:
benwells@chromium.org
Closed: Oct 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove logspam from external_web_apps.cc

Project Member Reported by michae...@chromium.org, Oct 21 
When I run unit tests, I get the following errors:

[238892:238892:1020/183103.378498:3220081841752:ERROR:external_web_apps.cc(176)] Determining directory
[238892:238892:1020/183103.378539:3220081841791:ERROR:external_web_apps.cc(207)] Scanning

Can these be demoted to VLOG(1) or at least INFO something?

If not, just remove them when debugging is completed. Thanks.

Comment 1 by benwells@chromium.org, Oct 22 

Yeah sorry about this. I need the logging in fully trusted devices (i.e. not dev mode) and this is the only way I know how. The logging will be removed soon.

Comment 2 by michae...@chromium.org, Oct 22 

Gotcha -- I'll just leave this bug open so we don't forget :-)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf74e5257fbb8f86d9775d28366fd63961ef6351

commit bf74e5257fbb8f86d9775d28366fd63961ef6351
Author: Ben Wells <benwells@chromium.org>
Date: Thu Oct 25 06:27:11 2018

Restore external_web_app logging to a reasonable level.

Lots of error logging was added to help debug a problem. This is not
needed any more so logging is being restored to a non-spammy level.

Bug:  897469 
Change-Id: Ie634806f8aaa5bf3316368d70527a652642cf762
Reviewed-on: https://chromium-review.googlesource.com/c/1297849
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602622}
[modify] https://crrev.com/bf74e5257fbb8f86d9775d28366fd63961ef6351/chrome/browser/web_applications/bookmark_apps/external_web_apps.cc

Comment 4 by benwells@chromium.org, Oct 25

Status: Fixed (was: Assigned)
►

Sign in to add a comment