New issue
Advanced search Search tips

Issue 897468 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros deploy --root=/usr/local --deep ... does not work

Project Member Reported by gwendal@chromium.org, Oct 21

Issue description

But the following works:
cros deploy --deep 
cros deploy --root=/usr/local --deep
cros deploy --root=/usr/local/ --deep

The problem is 
trees = portage.create_trees(target_root='/usr/local',config_root='/')

returns:
{u'/usr/local/': {u'virtuals': None, u'bintree': None, u'vartree': None, u'porttree': None}, u'/': {u'virtuals': None, u'bintree': None, u'vartree': None, u'porttree': None}}

And in GET_VARTREE (https://chromium.googlesource.com/chromiumos/chromite/+/master/cli/deploy.py#110)

we use the key /usr/local instead of /usr/local/ 
 
Owner: gwendal@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/99e6f531e4d86b184b32265ef28671e075d135d9

commit 99e6f531e4d86b184b32265ef28671e075d135d9
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Wed Nov 07 14:34:36 2018

cros deploy: Fix --root /usr/local --deep invocation

Portage require a trailing '/' for the root path. Add it when looking
for pacakges on the destination machine.

BUG=chromium:897468
TEST=Check cros deploy does not fail due to python error.

Change-Id: I6dbf213151e0f781979492b04f613ad9517a1e53
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1303055
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/99e6f531e4d86b184b32265ef28671e075d135d9/cli/deploy.py

Sign in to add a comment