New issue
Advanced search Search tips

Issue 897467 link

Starred by 3 users
Status: WontFix
Owner: ----
Closed: Oct 22
Cc:
eugene...@chromium.org
kkhorimoto@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

CRWWebControllerPageScrollStateTest always failing.

Project Member Reported by justincohen@chromium.org, Oct 21 
ios_web_unittests
ProgrammaticCRWWebControllerPageScrollStateTest/CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableEnabled/1
ProgrammaticCRWWebControllerPageScrollStateTest/CRWWebControllerPageScrollStateTest.FLAKY_SetPageDisplayStateWithUserScalableEnabled/0

Always failing at this point.  The tests are marked as flaky now -- should we just disable them until they are fixed?

See recent CI: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/38510

Comment 1 by pkl@chromium.org, Oct 22

Cc: kkhorimoto@chromium.org
Components: Tests>Flaky
+kkhorimoto - Are these tests new?
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1f22b29e9410634997256684397b112735be58d

commit f1f22b29e9410634997256684397b112735be58d
Author: Eugene But <eugenebut@google.com>
Date: Mon Oct 22 21:08:25 2018

Remove CRWWebControllerPageScrollStateTest.

This test tests implementation specific details, was a maintenance
burden for chrome and never caught regressions in page state restoration
code.

Given that state restoration is a part of CRWWebController, the only way
to test page state code is to write an EG test: crbug.com/897768

Removing this test does not really change anything, because the test has
been failing consistently for very long time.

Bug:  897467 
Change-Id: Iaff4a9dc60b720c280c73f00b29ebcae04994e1c
Reviewed-on: https://chromium-review.googlesource.com/c/1294196
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601724}
[modify] https://crrev.com/f1f22b29e9410634997256684397b112735be58d/ios/web/web_state/ui/crw_web_controller.h
[modify] https://crrev.com/f1f22b29e9410634997256684397b112735be58d/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/f1f22b29e9410634997256684397b112735be58d/ios/web/web_state/ui/crw_web_controller_unittest.mm

Comment 3 by eugene...@chromium.org, Oct 22

Status: WontFix (was: Untriaged)
Removed the test :)
►

Sign in to add a comment