New issue
Advanced search Search tips

Issue 897403 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::Node::GetTreeScope

Project Member Reported by ClusterFuzz, Oct 20

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5778351195947008

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  blink::Node::GetTreeScope
  blink::Node::GetDocument
  blink::RangeBoundaryPoint::DomTreeVersion
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=599574:599575

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5778351195947008

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 20

Components: Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 20

Labels: Test-Predator-Auto-Owner
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6b9a2fed10338d3be52b935414e6c87382ac7a75 (Handle sequential focus navigation starting point in shadow trees correctly).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Components: -Blink>DOM Blink>HTML>Focus
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fae6cadf4ad37c5c3294a8c05ce42af1f4114673

commit fae6cadf4ad37c5c3294a8c05ce42af1f4114673
Author: Kent Tamura <tkent@chromium.org>
Date: Mon Oct 22 09:53:33 2018

Focus navigation: Fix a null pointer dereference on disconnecting children including a focused shadow element

crrev.com/599575 fixed a case where a single host including a focused
shadow element is disconnected, but it didn't cover a case where
multiple children including a focused shadow element is disconnected.

Document::NodeChildrenWillBeRemoved() should handle sequential focus
navigation starting point like Document::NodeWillBeRemoved().

Bug:  897403 
Change-Id: I15c491ef9b789f1447be752f0ed41f4c7a8702a9
Reviewed-on: https://chromium-review.googlesource.com/c/1292664
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601510}
[modify] https://crrev.com/fae6cadf4ad37c5c3294a8c05ce42af1f4114673/third_party/WebKit/LayoutTests/fast/events/sequential-focus-navigation-starting-point.html
[modify] https://crrev.com/fae6cadf4ad37c5c3294a8c05ce42af1f4114673/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/fae6cadf4ad37c5c3294a8c05ce42af1f4114673/third_party/blink/renderer/core/dom/range.cc
[modify] https://crrev.com/fae6cadf4ad37c5c3294a8c05ce42af1f4114673/third_party/blink/renderer/core/dom/range.h

Project Member

Comment 5 by ClusterFuzz, Oct 24

ClusterFuzz has detected this issue as fixed in range 601509:601511.

Detailed report: https://clusterfuzz.com/testcase?key=5778351195947008

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  blink::Node::GetTreeScope
  blink::Node::GetDocument
  blink::RangeBoundaryPoint::DomTreeVersion
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=599574:599575
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=601509:601511

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5778351195947008

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Oct 24

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 5778351195947008 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment