New issue
Advanced search Search tips

Issue 897402 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in gpu::gles2::Framebuffer::GetReadBufferAttachment

Project Member Reported by ClusterFuzz, Oct 20

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5339037244850176

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000064
Crash State:
  gpu::gles2::Framebuffer::GetReadBufferAttachment
  gpu::gles2::Framebuffer::GetReadBufferIsMultisampledTexture
  gpu::gles2::GLES2DecoderImpl::HandleReadPixels
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=601355:601356

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5339037244850176

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 20

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 20

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Oct 20

Labels: Test-Predator-Auto-Owner
Owner: jdarpinian@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/98d07198bf8ca5d73651c727d229a4468b700d43 (Workaround for Qualcomm driver bug in glReadPixels.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by ClusterFuzz, Oct 20

Labels: OS-Windows
Project Member

Comment 5 by ClusterFuzz, Oct 21

Labels: OS-Mac
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc9e7dd586a2d1d53762c8e091df5a5c820e2b2

commit 5bc9e7dd586a2d1d53762c8e091df5a5c820e2b2
Author: James Darpinian <jdarpinian@chromium.org>
Date: Mon Oct 22 19:45:29 2018

Fix null dereference caught by ClusterFuzz.

In http://crrev.com/c/1279354, I didn't consider that the bound read
framebuffer can be NULL when reading from the default framebuffer.

Bug:  897402 ,  890002 
Change-Id: Id033ee7108d6bdceb9646e3e36595bfe667625a1
Reviewed-on: https://chromium-review.googlesource.com/c/1294401
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601691}
[modify] https://crrev.com/5bc9e7dd586a2d1d53762c8e091df5a5c820e2b2/gpu/command_buffer/service/gles2_cmd_decoder.cc

Status: Fixed (was: Assigned)
Should be fixed.
Project Member

Comment 8 by ClusterFuzz, Oct 23

ClusterFuzz has detected this issue as fixed in range 601676:601698.

Detailed report: https://clusterfuzz.com/testcase?key=5339037244850176

Fuzzer: libFuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000064
Crash State:
  gpu::gles2::Framebuffer::GetReadBufferAttachment
  gpu::gles2::Framebuffer::GetReadBufferIsMultisampledTexture
  gpu::gles2::GLES2DecoderImpl::HandleReadPixels
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=601355:601356
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=601676:601698

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5339037244850176

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Oct 23

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5339037244850176 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment