New issue
Advanced search Search tips

Issue 897394 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[git-cl] Collect push and Gerrit RPC requests information

Project Member Reported by ehmaldonado@google.com, Oct 20

Issue description

Collect performance data of git push and Gerrit RPC requests for git-cl.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/149834e67d308d632041c5600ea9d366e0ad9a6f

commit 149834e67d308d632041c5600ea9d366e0ad9a6f
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Oct 22 19:15:13 2018

metrics: Add function to collect repeated metrics.

Bug: 897394
Change-Id: Iece4507c7bf92d7a8aad045d31b4f06e54b3af15
Reviewed-on: https://chromium-review.googlesource.com/c/1292243
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/149834e67d308d632041c5600ea9d366e0ad9a6f/metrics.py
[modify] https://crrev.com/149834e67d308d632041c5600ea9d366e0ad9a6f/tests/metrics_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/71c0b83d1a778bde919a811c5576bcb8ce4c4f23

commit 71c0b83d1a778bde919a811c5576bcb8ce4c4f23
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Mon Oct 22 19:31:34 2018

depot_tools_metrics: Modify schema to support reporting http requests

Bug: 897394
Change-Id: Icb1d98680d63d251528b733a63435ce9af945ba6
Reviewed-on: https://chromium-review.googlesource.com/c/1292854
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18526}
[modify] https://crrev.com/71c0b83d1a778bde919a811c5576bcb8ce4c4f23/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json
[modify] https://crrev.com/71c0b83d1a778bde919a811c5576bcb8ce4c4f23/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.proto

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19846febaf8a2dc2b963184ac616f7c996d332c9

commit 19846febaf8a2dc2b963184ac616f7c996d332c9
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 22 21:35:51 2018

Roll src/third_party/depot_tools 98f1e59b41c6..149834e67d30 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/98f1e59b41c6..149834e67d30


git log 98f1e59b41c6..149834e67d30 --date=short --no-merges --format='%ad %ae %s'
2018-10-22 ehmaldonado@chromium.org metrics: Add function to collect repeated metrics.


Created with:
  gclient setdep -r src/third_party/depot_tools@149834e67d30

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897394
TBR=agable@chromium.org

Change-Id: I796b4e0e93af9e2319b05bf95a42a9f1f4d3d8b9
Reviewed-on: https://chromium-review.googlesource.com/c/1294226
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601733}
[modify] https://crrev.com/19846febaf8a2dc2b963184ac616f7c996d332c9/DEPS

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/03d6d1189692004bdf5378de766a5e0e25c7357e

commit 03d6d1189692004bdf5378de766a5e0e25c7357e
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Tue Oct 23 15:17:36 2018

metrics: Add function to extract metrics from HTTP requests

Bug: 897394
Change-Id: I92d2514e4347f02dbcf2884bef3a073095ee03a3
Reviewed-on: https://chromium-review.googlesource.com/c/1292242
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/03d6d1189692004bdf5378de766a5e0e25c7357e/tests/metrics_test.py
[modify] https://crrev.com/03d6d1189692004bdf5378de766a5e0e25c7357e/metrics_utils.py

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ca0bdcbf2c5c2b327c62d37a43810c01e9a4fdd

commit 3ca0bdcbf2c5c2b327c62d37a43810c01e9a4fdd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Oct 23 16:54:07 2018

Roll src/third_party/depot_tools 149834e67d30..03d6d1189692 (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/149834e67d30..03d6d1189692


git log 149834e67d30..03d6d1189692 --date=short --no-merges --format='%ad %ae %s'
2018-10-23 ehmaldonado@chromium.org metrics: Add function to extract metrics from HTTP requests


Created with:
  gclient setdep -r src/third_party/depot_tools@03d6d1189692

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897394
TBR=agable@chromium.org

Change-Id: If08d68fb652b36b6b8a397b2ab5c153dc5c1b666
Reviewed-on: https://chromium-review.googlesource.com/c/1296789
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601987}
[modify] https://crrev.com/3ca0bdcbf2c5c2b327c62d37a43810c01e9a4fdd/DEPS

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6838dc555f407cd3944cb267f7df212a26df8c52

commit 6838dc555f407cd3944cb267f7df212a26df8c52
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Oct 31 04:29:22 2018

Roll src/third_party/depot_tools f170af48e449..9afc6490c148 (4 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f170af48e449..9afc6490c148


git log f170af48e449..9afc6490c148 --date=short --no-merges --format='%ad %ae %s'
2018-10-30 martiniss@google.com Manual roll for new run logic
2018-10-30 ehmaldonado@chromium.org git-cl: Report Gerrit RPC requests information.
2018-10-30 tandrii@chromium.org git cl upload: set CQ and Auto Submit labels through refspec.
2018-10-30 tandrii@chromium.org git cl upload: cc + reviewers in git push for chromium host.


Created with:
  gclient setdep -r src/third_party/depot_tools@9afc6490c148

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:646142,chromium:897394, chromium:877717 , chromium:877717 
TBR=agable@chromium.org

Change-Id: I5adb7abe91c8c607d94920bb83bc01d7bb9559d8
Reviewed-on: https://chromium-review.googlesource.com/c/1308703
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604151}
[modify] https://crrev.com/6838dc555f407cd3944cb267f7df212a26df8c52/DEPS

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d71e5ab59a5f102e20d4c49f97db66dc7f4a458d

commit d71e5ab59a5f102e20d4c49f97db66dc7f4a458d
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Wed Oct 31 18:27:30 2018

depot_tools_metrics: Modify schema to accept sub-commands.

Bug: 897394
Change-Id: I5a58436f76f58726d233f241075d78d4b7c90ac1
Reviewed-on: https://chromium-review.googlesource.com/c/1308538
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18698}
[modify] https://crrev.com/d71e5ab59a5f102e20d4c49f97db66dc7f4a458d/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json
[modify] https://crrev.com/d71e5ab59a5f102e20d4c49f97db66dc7f4a458d/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.proto

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/fec80c41355c59f356229dc223808d5c22c87a47

commit fec80c41355c59f356229dc223808d5c22c87a47
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Nov 01 23:14:14 2018

git-cl: Report git push information to metrics collection.

Bug: 897394
Change-Id: I52a31bb4840b5de89b96545a3e7544c6708f148f
Reviewed-on: https://chromium-review.googlesource.com/c/1312240
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/fec80c41355c59f356229dc223808d5c22c87a47/metrics_utils.py
[modify] https://crrev.com/fec80c41355c59f356229dc223808d5c22c87a47/tests/metrics_test.py
[modify] https://crrev.com/fec80c41355c59f356229dc223808d5c22c87a47/git_cl.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/61023e9f3771ce9188ba8f1d0d745deac64e7bc5

commit 61023e9f3771ce9188ba8f1d0d745deac64e7bc5
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Thu Nov 01 23:44:50 2018

depot_tools_metrics: Add "m" as a valid subcommand arg.

Tbr: tandrii@chromium.org
Bug: 897394
Change-Id: Ib4e7b3bd6a176506bffaad61dad5fd00178d2190
Reviewed-on: https://chromium-review.googlesource.com/c/1313654
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#18746}
[modify] https://crrev.com/61023e9f3771ce9188ba8f1d0d745deac64e7bc5/go/src/infra/appengine/depot_tools_metrics/metrics/metrics_schema.json

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06a4af6636b25f0ec65e227e188960cb7a07980f

commit 06a4af6636b25f0ec65e227e188960cb7a07980f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Nov 02 02:56:34 2018

Roll src/third_party/depot_tools 8f8a50d00a8b..fec80c41355c (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f8a50d00a8b..fec80c41355c


git log 8f8a50d00a8b..fec80c41355c --date=short --no-merges --format='%ad %ae %s'
2018-11-01 ehmaldonado@chromium.org git-cl: Report git push information to metrics collection.


Created with:
  gclient setdep -r src/third_party/depot_tools@fec80c41355c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897394
TBR=agable@chromium.org

Change-Id: Ie1478e08383e456d754435c88cad4c980afcbb4f
Reviewed-on: https://chromium-review.googlesource.com/c/1313295
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604817}
[modify] https://crrev.com/06a4af6636b25f0ec65e227e188960cb7a07980f/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e2a36d0eb73ff0e097dcbd81d273c567d4766f7

commit 3e2a36d0eb73ff0e097dcbd81d273c567d4766f7
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Sat Nov 03 04:47:03 2018

Roll src/third_party/depot_tools a98da076b9e5..7e0b0c498a5c (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a98da076b9e5..7e0b0c498a5c


git log a98da076b9e5..7e0b0c498a5c --date=short --no-merges --format='%ad %ae %s'
2018-11-03 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-03 ehmaldonado@chromium.org git-cl: Add tests for metrics collection.


Created with:
  gclient setdep -r src/third_party/depot_tools@7e0b0c498a5c

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:897394
TBR=agable@chromium.org

Change-Id: I015df12f8d81089c8a2f3371b68f8e117428b9c7
Reviewed-on: https://chromium-review.googlesource.com/c/1316856
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605151}
[modify] https://crrev.com/3e2a36d0eb73ff0e097dcbd81d273c567d4766f7/DEPS

Sign in to add a comment