Flaky test: PreviewsUITabHelperUnitTest.DidFinishNavigationDoesCreateLoFiPreviewsInfoBar Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/53650 Test output log: https://chromium-swarm.appspot.com/task?id=40a77a00e21ecd10 Culprit (95.2% confidence): r601298 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81MzY1MC91bml0X3Rlc3RzL1VISmxkbWxsZDNOVlNWUmhZa2hsYkhCbGNsVnVhWFJVWlhOMExrUnBaRVpwYm1semFFNWhkbWxuWVhScGIyNUViMlZ6UTNKbFlYUmxURzlHYVZCeVpYWnBaWGR6U1c1bWIwSmhjZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PreviewsUITabHelperUnitTest.DidFinishNavigationDoesCreateLoFiPreviewsInfoBar&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2AELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKhAWNocm9taXVtLmxpbnV4L0xpbnV4IFRlc3RzIChkYmcpKDEpKDMyKS81MzY1MC91bml0X3Rlc3RzL1VISmxkbWxsZDNOVlNWUmhZa2hsYkhCbGNsVnVhWFJVWlhOMExrUnBaRVpwYm1semFFNWhkbWxuWVhScGIyNUViMlZ6UTNKbFlYUmxURzlHYVZCeVpYWnBaWGR6U1c1bWIwSmhjZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Reverting now. I'll look at the failure on Monday, and see what went wrong.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa05092ff325c9ff71f215499c28f6f26a06707c commit aa05092ff325c9ff71f215499c28f6f26a06707c Author: Ryan Sturm <ryansturm@chromium.org> Date: Sun Oct 21 03:56:54 2018 Reland "Switching Previews triggering from the IO thread to the UI thread" This is a reland of 310c6fa1909da00f001303a6498878e987487b8a This was caused by a CL that landed on Friday morning that was missing a RunUntilIdle (that was added for the rest of the tests in the file). https://chromium-review.googlesource.com/c/chromium/src/+/1289086 added the failing test. The delta for the reland is adding a RunUntilIdle. Original change's description: > Switching Previews triggering from the IO thread to the UI thread > > This CL moves previews triggering from the IO thread > (ChromeResourceDispatcherHostDelegate) to the UI thread > (ChromeContentBrowserClient). The new call sites occur in > NavigationRequest and update the previews_state in > CommonNavigationParams held by the NavigationRequest directly. This > means PreviewsDeciderImpl is being moved to the UI thread. > > Significant changes: > - PreviewsDeciderImpl is now owned by the PreviewsUIService instead of > profile IO data. > - PreviewsUserData is now entirely a UI thread notion. For now, we use > PreviewsUITabHelper to manage its lifetime, but it could move to > NavigationHandle (if NavigationHandle already supported UserData, > that solution would be ideal). > - ChromeNavigationData is update to remove PreviewsUserData and > PreviewsState (the latter has moved into PreviewsUserData and there is a > notion of Allowed PreviewsState and committed PreviewsState) > - Offline Previews committed checks use the OfflinePreviewsTabHelper > instead of PreviewsUserData now that we are on the same thread. > - Cleanup on ResourceRequestInfo to remove PreviewsState setter as well > as cleanup to remove PreviewsState from being passed back out of the > loader code into NavigationRequest. > - There is a TODO to re-evaluate PreviewsState during redirects, which > will *not* be plumbed into the network service, so DataReductionProxy > Previews will not be updated. > > Bug: 842233 > Change-Id: I80a3044a4c84734b877f8ebcbe5a4bb2c2900dbb > Reviewed-on: https://chromium-review.googlesource.com/c/1266196 > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Jian Li <jianli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601298} Bug: 842233 , 897385 Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 TBR=jochen@chromium.org,clamy@chromium.org,tbansal@chromium.org,mmenke@chromium.org,jianli@chromium.org Change-Id: I4ff029a45edf3a1ac84f409fb3326d6767f03fd8 Reviewed-on: https://chromium-review.googlesource.com/c/1292955 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#601426} [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_navigation_data_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/loader/chrome_resource_dispatcher_host_delegate_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/background_loader_offliner.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/background_loader_offliner_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/offline_page_request_handler_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/offline_pages/offline_page_request_job.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_ukm_observer.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/page_load_metrics/observers/previews_ukm_observer_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_infobar_delegate_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_service_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/previews_ui_tab_helper_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/previews/resource_loading_hints/resource_loading_hints_web_contents_observer.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_impl_io_data.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/profiles/profile_io_data.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/optimization_guide/optimization_guide_service.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/optimization_guide/optimization_guide_service.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_content_util_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_decider_impl_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_ui_service_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/components/previews/content/previews_user_data_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_controller_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/frame_host/navigation_request.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/loader_browsertest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/mojo_async_resource_handler_unittest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_delegate.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/navigation_url_loader_impl.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_request_info_impl.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/loader/resource_request_info_impl.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/browser/navigation_browsertest.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/content_browser_client.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/content_browser_client.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_dispatcher_host_delegate.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_dispatcher_host_delegate.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/public/browser/resource_request_info.h [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader_delegate.cc [modify] https://crrev.com/aa05092ff325c9ff71f215499c28f6f26a06707c/content/test/test_navigation_url_loader_delegate.h
Comment 1 by ryansturm@chromium.org
, Oct 20