Cleanup Views Examples |
|||||||
Issue descriptionCleanup and Make Views Examples easier to see and use.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/502529c19a3023f02e6a34a72c2584981796fe53 commit 502529c19a3023f02e6a34a72c2584981796fe53 Author: Robert Liao <robliao@chromium.org> Date: Tue Oct 23 16:14:31 2018 Fix Closing Views Examples http://crrev.com/593230 removed a call to base::RunLoop::QuitCurrentWhenIdleDeprecated() and plumbed the quit closure to ExamplesWindowContents. However, when ExamplesWindowContents is created, the RunLoop driving the main thread hasn't yet been created and as a result, the quit closure isn't set. This means when ExamplesWindowContents closes, the RunLoop happily continues running. The fix here moves the RunLoop creation earlier so that the QuitClosure can be passed through to ExamplesWindowContents. BUG=897377 Change-Id: I1c14f090be2756dc049d7afcc857b10b31912d3e Reviewed-on: https://chromium-review.googlesource.com/c/1292829 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#601975} [modify] https://crrev.com/502529c19a3023f02e6a34a72c2584981796fe53/ui/views_content_client/views_content_client_main_parts.cc [modify] https://crrev.com/502529c19a3023f02e6a34a72c2584981796fe53/ui/views_content_client/views_content_client_main_parts.h
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6 commit 7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6 Author: Robert Liao <robliao@chromium.org> Date: Tue Oct 23 23:45:43 2018 Split the Combobox Example Model into Three Models This simplifies lifetime handling for these comboboxes. BUG=897377 Change-Id: I19e8ed25f8e6b17012669ad7e810d33aa28d8ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1295589 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602174} [modify] https://crrev.com/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6/ui/views/examples/combobox_example.cc [modify] https://crrev.com/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6/ui/views/examples/combobox_example.h
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6 commit 7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6 Author: Robert Liao <robliao@chromium.org> Date: Tue Oct 23 23:45:43 2018 Split the Combobox Example Model into Three Models This simplifies lifetime handling for these comboboxes. BUG=897377 Change-Id: I19e8ed25f8e6b17012669ad7e810d33aa28d8ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1295589 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#602174} [modify] https://crrev.com/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6/ui/views/examples/combobox_example.cc [modify] https://crrev.com/7ad8c0367ef9eb62e498cf9f7cea58f2859bb0d6/ui/views/examples/combobox_example.h
,
Oct 25
,
Oct 25
,
Oct 26
,
Oct 26
,
Nov 15
***UI Mass Triage*** Since work is in progress, adding appropriate labels.
,
Dec 11
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by robliao@chromium.org
, Oct 22