Uncaught exception error during results page load for telemetry. |
|||||
Issue description
Used the following command locally to run a telemetry benchmark on Android.
./tools/perf/run_benchmark rendering.mobile --story-tag-filter=motionmark --story-filter=anim_images_50 --browser=android-chromium --extra-browser-args="--enable-oop-rasterization" --pageset-repeat=5 --results-label=oop --reset-results
./tools/perf/run_benchmark rendering.mobile --story-tag-filter=motionmark --story-filter=anim_images_50 --browser=android-chromium --extra-browser-args="--disable-oop-rasterization" --pageset-repeat=5 --results-label=gpu
The page loads fine after the first run, but I see this error in the console after the second run.
Uncaught (in promise) Error: Unable to find shared Diagnostic d67ca65d-fcef-4577-b431-b759fafe0a27
at Map.resolveSharedDiagnostics (results.html:16159)
at HistogramSet.importDict (results.html:18140)
at HistogramImporter.loadSomeHistograms_ (results.html:18464)
at HistogramImporter.loadSomeHistograms_ (results.html:18471)
And the page is stuck at "Loading Histogram 155"
,
Oct 19
,
Oct 20
As soon as I do another run (even with the same label), I run into a similar error. However pageset-repeat doesn't seem to run into this error.
,
Oct 22
This is still happening. benjhayden@, could I assign this to you for triaging?
,
Oct 22
Looking. Suspect https://chromium-review.googlesource.com/c/catapult/+/1249145
,
Oct 22
Reverting that locally appears to fix the issues for me. Thanks!
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0339f0866c5f57f51354ee309a8fcff58fecae74 commit 0339f0866c5f57f51354ee309a8fcff58fecae74 Author: Camillo Bruni <cbruni@chromium.org> Date: Mon Oct 22 22:26:15 2018 [tracing] Do not skip over entries when importing histograms With the new html comment based format the histogram_import would skip over one entry when entering loadSomeHistograms_ again. This is fixed by only looking once for the data start in findDataStart_. Change-Id: I4379a01af2809cfa03e6cdc8c368dfd7e27547dc Bug: chromium:897372 Reviewed-on: https://chromium-review.googlesource.com/c/1294032 Commit-Queue: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> [modify] https://crrev.com/0339f0866c5f57f51354ee309a8fcff58fecae74/tracing/tracing/value/ui/histogram_importer_test.html [modify] https://crrev.com/0339f0866c5f57f51354ee309a8fcff58fecae74/tracing/tracing_build/render_histograms_viewer.py [modify] https://crrev.com/0339f0866c5f57f51354ee309a8fcff58fecae74/tracing/tracing/value/histogram_importer.html [modify] https://crrev.com/0339f0866c5f57f51354ee309a8fcff58fecae74/tracing/tracing_build/render_histograms_viewer_unittest.py
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1743476ba6e62bf38ab998679c95aae60593b559 commit 1743476ba6e62bf38ab998679c95aae60593b559 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Oct 22 23:57:05 2018 Roll src/third_party/catapult b145370ba063..0339f0866c5f (1 commits) https://chromium.googlesource.com/catapult.git/+log/b145370ba063..0339f0866c5f git log b145370ba063..0339f0866c5f --date=short --no-merges --format='%ad %ae %s' 2018-10-22 cbruni@chromium.org [tracing] Do not skip over entries when importing histograms Created with: gclient setdep -r src/third_party/catapult@0339f0866c5f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:897372 TBR=sullivan@chromium.org Change-Id: I74635f52def221f71e6d35462bd405ddc3ca25dc Reviewed-on: https://chromium-review.googlesource.com/c/1295031 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601787} [modify] https://crrev.com/1743476ba6e62bf38ab998679c95aae60593b559/DEPS
,
Oct 23
This should be fixed now with the latest roll, sorry for the inconvenience! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by khushals...@chromium.org
, Oct 19