New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897369 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 883032



Sign in to add a comment

faster background blur with content scale for launcher

Project Member Reported by osh...@chromium.org, Oct 19

Issue description

I confirmed with jenn/sgabriel/ben that we can go with 0.5 scale.
 
Blocking: 883032
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7

commit 60b6acc12a2369e970f4e2fa2e3845a8e2f85de7
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Mon Oct 29 22:09:52 2018

ui/cc: Add Layer::SetBackdropFilterQuality

Computing background blur at full resolution as a backdrop
filter turned out not to be cheap.

This patch adds a backdrop_filter_quality float to cc::Layer
that can be used to reduce the size of the offscreen canvas
used to compute the blur.

Currently this float is not exposed on the web and can be used
only from Chrome UI.

Bug:  897369 

Change-Id: Ia070772ba576b37a8ee399c3c70b3e2308397e41
Reviewed-on: https://chromium-review.googlesource.com/c/1300235
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603649}
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/layers/layer.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/layers/layer.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/trees/effect_node.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/common/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/common/quads/render_pass_draw_quad.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/common/quads/render_pass_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/ui/compositor/layer.cc
[modify] https://crrev.com/60b6acc12a2369e970f4e2fa2e3845a8e2f85de7/ui/compositor/layer.h

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3856a7a9a32d02b0aaeb143728c26161ec4b54cb

commit 3856a7a9a32d02b0aaeb143728c26161ec4b54cb
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Mon Oct 29 22:35:07 2018

ui: Lower applist and shelf blur quality

crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

Bug:  897369 
Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43
Reviewed-on: https://chromium-review.googlesource.com/c/1306234
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603660}
[modify] https://crrev.com/3856a7a9a32d02b0aaeb143728c26161ec4b54cb/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/3856a7a9a32d02b0aaeb143728c26161ec4b54cb/ash/shelf/shelf_widget.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d911211dc4ba03ea88c58a55ad0745a5194ebf80

commit d911211dc4ba03ea88c58a55ad0745a5194ebf80
Author: Takashi Sakamoto <tasak@google.com>
Date: Tue Oct 30 02:12:28 2018

Revert "ui/cc: Add Layer::SetBackdropFilterQuality"

This reverts commit 60b6acc12a2369e970f4e2fa2e3845a8e2f85de7.

Reason for revert: 
Suspect WebKit Linux Trusty MSAN falure.

 animations/responsive/filter-responsive-neutral-keyframe.html
 animations/svg/animated-filter-svg-element.html
 compositing/child-layer-3d-sorting.html
 compositing/child-transform-layer-with-foreground-layer.html
 compositing/clip-path-with-composited-descendants.html
 compositing/composited-descendant-grandparent-border-radius-mask.html
 compositing/composited-descendant-requiring-border-radius-mask.html
 compositing/composited-scaled-child-with-border-radius-parent-clip.html
 compositing/composited-translated-child-with-border-radius-parent-clip.html
 compositing/direct-image-compositing.html
 compositing/flat-with-transformed-child.html
...
are crashed.

Example:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/10739

Log:
STDERR:   Uninitialized value was stored to memory at
STDERR:     #0 0xfee509c in SetAll ./../../components/viz/common/quads/render_pass_draw_quad.cc:69:33
STDERR:     #1 0xfee509c in viz::RenderPassDrawQuad::SetNew(viz::SharedQuadState const*, gfx::Rect const&, gfx::Rect const&, unsigned long, unsigned int, gfx::RectF const&, gfx::Size const&, gfx::Vector2dF const&, gfx::PointF const&, gfx::RectF const&, bool, float) ./../../components/viz/common/quads/render_pass_draw_quad.cc:37:0
STDERR:     #2 0x101b9bd4 in cc::RenderSurfaceImpl::AppendQuads(cc::DrawMode, viz::RenderPass*, cc::AppendQuadsData*) ./../../cc/layers/render_surface_impl.cc:464:9
STDERR:     #3 0x102419cf in cc::LayerTreeHostImpl::CalculateRenderPasses(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/layer_tree_host_impl.cc:1095:25
STDERR:     #4 0x1024cb03 in cc::LayerTreeHostImpl::PrepareToDraw(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/layer_tree_host_impl.cc:1389:28
STDERR:     #5 0x1058547e in cc::SingleThreadProxy::DoComposite(cc::LayerTreeHostImpl::FrameData*) ./../../cc/trees/single_thread_proxy.cc:623:31
STDERR:     #6 0x10584813 in cc::SingleThreadProxy::CompositeImmediately(base::TimeTicks, bool) ./../../cc/trees/single_thread_proxy.cc:566:7

Original change's description:
> ui/cc: Add Layer::SetBackdropFilterQuality
> 
> Computing background blur at full resolution as a backdrop
> filter turned out not to be cheap.
> 
> This patch adds a backdrop_filter_quality float to cc::Layer
> that can be used to reduce the size of the offscreen canvas
> used to compute the blur.
> 
> Currently this float is not exposed on the web and can be used
> only from Chrome UI.
> 
> Bug:  897369 
> 
> Change-Id: Ia070772ba576b37a8ee399c3c70b3e2308397e41
> Reviewed-on: https://chromium-review.googlesource.com/c/1300235
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: ccameron <ccameron@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603649}

TBR=oshima@chromium.org,ccameron@chromium.org,enne@chromium.org,senorblanco@chromium.org,dcastagna@chromium.org,rsesek@chromium.org

Change-Id: I3f83c5aec525ba4199ef9cdb1c21e1fbe62b2fe0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  897369 
Reviewed-on: https://chromium-review.googlesource.com/c/1306934
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#603738}
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/layers/layer.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/layers/layer.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/trees/effect_node.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/common/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/common/quads/render_pass_draw_quad.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/common/quads/render_pass_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/ui/compositor/layer.cc
[modify] https://crrev.com/d911211dc4ba03ea88c58a55ad0745a5194ebf80/ui/compositor/layer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b75ca717c92673139447b965fd179450a5d55bd

commit 0b75ca717c92673139447b965fd179450a5d55bd
Author: Chase Phillips <cmp@chromium.org>
Date: Tue Oct 30 02:31:50 2018

Revert "ui: Lower applist and shelf blur quality"

This reverts commit 3856a7a9a32d02b0aaeb143728c26161ec4b54cb.

Reason for revert:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-daisy-rel/35823
failed in compile:
FAILED: obj/ash/app_list/app_list/app_list_view.o 
...
-c ../../ash/app_list/views/app_list_view.cc -o obj/ash/app_list/app_list/app_list_view.o
../../ash/app_list/views/app_list_view.cc:513:43: error: no member named 'SetBackdropFilterQuality' in 'ui::Layer'
    app_list_background_shield_->layer()->SetBackdropFilterQuality(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ^
1 error generated.

Original change's description:
> ui: Lower applist and shelf blur quality
> 
> crrev.com/c/1300235 introduced the option to lower the quality of backdrop
> filters.
> 
> This CL lowers the quality of the backdrop blur one the shelf and the
> applist shield.
> 
> In this way the texture allocations needed to apply the filter by cc will
> be significantly smaller/faster and applying the filter itself will also
> be faster on the GPU.
> 
> Bug:  897369 
> Change-Id: I57be9434c02b77b38315e0f998d23eda5d277e43
> Reviewed-on: https://chromium-review.googlesource.com/c/1306234
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603660}

TBR=oshima@chromium.org,dcastagna@chromium.org

Change-Id: Ie3fb29b6d37cd8b409ab5ac910b39a1c52531c6e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  897369 
Reviewed-on: https://chromium-review.googlesource.com/c/1307058
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603746}
[modify] https://crrev.com/0b75ca717c92673139447b965fd179450a5d55bd/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/0b75ca717c92673139447b965fd179450a5d55bd/ash/shelf/shelf_widget.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532

commit 8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Tue Oct 30 17:19:02 2018

Reland of "ui/cc: Add Layer::SetBackdropFilterQuality"

The original CL crrev.com/c/1300235 got reverted since we were not
initializing the new added member EffectNode::backdrop_filter_quality.
This CL initializes it and additionally fixes EffectNode::operator==.

Origianl CL description:
Computing background blur at full resolution as a backdrop
filter turned out not to be cheap.

This patch adds a backdrop_filter_quality float to cc::Layer
that can be used to reduce the size of the offscreen canvas
used to compute the blur.

Currently this float is not exposed on the web and can be used
only from Chrome UI.

TBR=enne@chromium.org, ccameron@chromium.org, rsesek@chromium.org, oshima@chromium.org

Bug:  897369 
Change-Id: Ibf7594b7a97d8e752890c691ed14dff12266013d
Reviewed-on: https://chromium-review.googlesource.com/c/1307591
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603937}
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/layers/layer.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/layers/layer.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/trees/effect_node.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/trees/effect_node.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/common/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/common/quads/render_pass_draw_quad.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/common/quads/render_pass_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/ui/compositor/layer.cc
[modify] https://crrev.com/8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532/ui/compositor/layer.h

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c92f015f019b575c3dc5b64b182a78ecf254ef2b

commit c92f015f019b575c3dc5b64b182a78ecf254ef2b
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Tue Oct 30 18:34:07 2018

Reland of "ui: Lower applist and shelf blur quality"

This CL was reverted since it depends on a CL that introduced MSAN issues.
Relanding as it is after the MSAN issues have been addressed.

Origianal description:
crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

Bug:  897369 
Change-Id: Id56368bbdb18b9e7ec3a284e79ab76c04ec3bf8e
TBR: oshima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308036
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603970}
[modify] https://crrev.com/c92f015f019b575c3dc5b64b182a78ecf254ef2b/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/c92f015f019b575c3dc5b64b182a78ecf254ef2b/ash/shelf/shelf_widget.cc

Labels: Merge-Request-71
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 31

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
A lot of CLs here and many changes for so late in M71.  Which CLs apply for this specific request?

Also, Per the M71 Branch Announcement: "Have your change checked into the trunk, and tested by you on either a Canary build or Dev channel release before asking for merge approval."   Has this testing taken place?  If so, results?  If not, please test prior to the merge request.  Thanks.

Labels: Merge-Request-71
We need to merge one in #7. This is part of performannce tuning work required for m71. This has been tested on 72.0.3601.0/11231.0.0 and improved FPS of launcher dragging by 10 on target machine.
Project Member

Comment 12 by sheriffbot@chromium.org, Nov 6

Labels: -Merge-Request-71
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Merge approved for ChromeOS M71
I also have to merge #6. I talked to geohsu@ over hangout and got approval for extra merge.
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 6

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21cfa0700f540de9384c161b7deb2fc4f7e731b2

commit 21cfa0700f540de9384c161b7deb2fc4f7e731b2
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Nov 06 20:51:14 2018

Reland of "ui/cc: Add Layer::SetBackdropFilterQuality"

The original CL crrev.com/c/1300235 got reverted since we were not
initializing the new added member EffectNode::backdrop_filter_quality.
This CL initializes it and additionally fixes EffectNode::operator==.

Origianl CL description:
Computing background blur at full resolution as a backdrop
filter turned out not to be cheap.

This patch adds a backdrop_filter_quality float to cc::Layer
that can be used to reduce the size of the offscreen canvas
used to compute the blur.

Currently this float is not exposed on the web and can be used
only from Chrome UI.

TBR=enne@chromium.org, ccameron@chromium.org, rsesek@chromium.org, oshima@chromium.org

(cherry picked from commit 8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532)

Bug:  897369 
Reviewed-on: https://chromium-review.googlesource.com/c/1307591
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#603937}
Change-Id: Id56368bbdb18b9e7ec3a284e79ab76c04ec3bf8e
Reviewed-on: https://chromium-review.googlesource.com/c/1320470
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#544}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/layers/layer.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/layers/layer.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/layers/layer_impl_test_properties.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/test/render_pass_test_utils.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/trees/effect_node.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/trees/effect_node.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/common/quads/draw_quad_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/common/quads/render_pass_draw_quad.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/common/quads/render_pass_draw_quad.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/common/quads/render_pass_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/display_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/gl_renderer.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/gl_renderer.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/overlay_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/components/viz/test/surface_hittest_test_helpers.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/services/viz/public/cpp/compositing/quads_struct_traits.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/services/viz/public/cpp/compositing/quads_struct_traits.h
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/services/viz/public/cpp/compositing/struct_traits_unittest.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/services/viz/public/interfaces/compositing/quads.mojom
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/ui/compositor/layer.cc
[modify] https://crrev.com/21cfa0700f540de9384c161b7deb2fc4f7e731b2/ui/compositor/layer.h

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/21cfa0700f540de9384c161b7deb2fc4f7e731b2

Commit: 21cfa0700f540de9384c161b7deb2fc4f7e731b2
Author: oshima@chromium.org
Commiter: oshima@chromium.org
Date: 2018-11-06 20:51:14 +0000 UTC

Reland of "ui/cc: Add Layer::SetBackdropFilterQuality"

The original CL crrev.com/c/1300235 got reverted since we were not
initializing the new added member EffectNode::backdrop_filter_quality.
This CL initializes it and additionally fixes EffectNode::operator==.

Origianl CL description:
Computing background blur at full resolution as a backdrop
filter turned out not to be cheap.

This patch adds a backdrop_filter_quality float to cc::Layer
that can be used to reduce the size of the offscreen canvas
used to compute the blur.

Currently this float is not exposed on the web and can be used
only from Chrome UI.

TBR=enne@chromium.org, ccameron@chromium.org, rsesek@chromium.org, oshima@chromium.org

(cherry picked from commit 8dc4d36e66e6b9f1506efa56fcffc97d5c7f1532)

Bug:  897369 
Reviewed-on: https://chromium-review.googlesource.com/c/1307591
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#603937}
Change-Id: Id56368bbdb18b9e7ec3a284e79ab76c04ec3bf8e
Reviewed-on: https://chromium-review.googlesource.com/c/1320470
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#544}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02d114f8b6c48997dc5a3cc70a0d0d526dc994cc

commit 02d114f8b6c48997dc5a3cc70a0d0d526dc994cc
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Tue Nov 06 21:06:22 2018

Reland of "ui: Lower applist and shelf blur quality"

This CL was reverted since it depends on a CL that introduced MSAN issues.
Relanding as it is after the MSAN issues have been addressed.

Origianal description:
crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

(cherry picked from commit c92f015f019b575c3dc5b64b182a78ecf254ef2b)

Bug:  897369 
Change-Id: I16507333bde1425cdac9bd6c075a6903bdcd863a
TBR: oshima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308036
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603970}
Reviewed-on: https://chromium-review.googlesource.com/c/1320518
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#545}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/02d114f8b6c48997dc5a3cc70a0d0d526dc994cc/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/02d114f8b6c48997dc5a3cc70a0d0d526dc994cc/ash/shelf/shelf_widget.cc

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/02d114f8b6c48997dc5a3cc70a0d0d526dc994cc

Commit: 02d114f8b6c48997dc5a3cc70a0d0d526dc994cc
Author: oshima@chromium.org
Commiter: oshima@chromium.org
Date: 2018-11-06 21:06:22 +0000 UTC

Reland of "ui: Lower applist and shelf blur quality"

This CL was reverted since it depends on a CL that introduced MSAN issues.
Relanding as it is after the MSAN issues have been addressed.

Origianal description:
crrev.com/c/1300235 introduced the option to lower the quality of backdrop
filters.

This CL lowers the quality of the backdrop blur one the shelf and the
applist shield.

In this way the texture allocations needed to apply the filter by cc will
be significantly smaller/faster and applying the filter itself will also
be faster on the GPU.

(cherry picked from commit c92f015f019b575c3dc5b64b182a78ecf254ef2b)

Bug:  897369 
Change-Id: I16507333bde1425cdac9bd6c075a6903bdcd863a
TBR: oshima@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308036
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#603970}
Reviewed-on: https://chromium-review.googlesource.com/c/1320518
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#545}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Assigned)

Sign in to add a comment