New issue
Advanced search Search tips

Issue 897365 link

Starred by 2 users
Status: Started
Owner:
anastasi@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility

Blocking:
issue 593885



Sign in to add a comment

Comprehensive Testing of Switch Access

Project Member Reported by zhelfins@chromium.org, Oct 19 
Currently, Switch Access has a small number of unit tests that are not run on presubmit, and so are frequently broken. We would like to improve the current unit test coverage and add additional coverage to have a more comprehensive overall testing suite, including end-to-end tests of the feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4860fede0e2dc63d6500f98bfe913921959c795

commit d4860fede0e2dc63d6500f98bfe913921959c795
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Tue Nov 06 17:16:38 2018

Update existing Switch Access tests

Bug: 897365
Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9
Reviewed-on: https://chromium-review.googlesource.com/c/1306787
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605719}
[modify] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[add] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_test.extjs
[delete] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs
[modify] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/switch_access.js
[add] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js
[add] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_test.extjs
[delete] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_unittest.gtestjs
[delete] https://crrev.com/05af02c8afe6a0fdc3d5e32ff88632fa15f5c567/chrome/browser/resources/chromeos/switch_access/test_support.js
[modify] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/chrome/test/BUILD.gn
[modify] https://crrev.com/d4860fede0e2dc63d6500f98bfe913921959c795/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572fb8c1374c665bfc5f78928d328b6c602cb20d

commit 572fb8c1374c665bfc5f78928d328b6c602cb20d
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Nov 06 17:44:13 2018

Revert "Update existing Switch Access tests"

This reverts commit d4860fede0e2dc63d6500f98bfe913921959c795.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 605719 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2Q0ODYwZmVkZTBlMmRjNjNkNjUwMGY5OGJmZTkxMzkyMTk1OWM3OTUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/Linux%20ChromiumOS%20Full/109223

Sample Failed Step: compile

Original change's description:
> Update existing Switch Access tests
> 
> Bug: 897365
> Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9
> Reviewed-on: https://chromium-review.googlesource.com/c/1306787
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605719}

Change-Id: I582f1a3f539ad62742fd4f39e3b004fbc00b974b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897365
Reviewed-on: https://chromium-review.googlesource.com/c/1320014
Cr-Commit-Position: refs/heads/master@{#605723}
[modify] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[delete] https://crrev.com/017bfb35e082e4ca7c859f4f626efa21904c7432/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_test.extjs
[add] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs
[modify] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/switch_access.js
[delete] https://crrev.com/017bfb35e082e4ca7c859f4f626efa21904c7432/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js
[delete] https://crrev.com/017bfb35e082e4ca7c859f4f626efa21904c7432/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_test.extjs
[add] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_unittest.gtestjs
[add] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/browser/resources/chromeos/switch_access/test_support.js
[modify] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/chrome/test/BUILD.gn
[modify] https://crrev.com/572fb8c1374c665bfc5f78928d328b6c602cb20d/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b159c717a1a33f5cb7bf65817383a8062f67b7d8

commit b159c717a1a33f5cb7bf65817383a8062f67b7d8
Author: Zach Helfinstein <zhelfins@chromium.org>
Date: Tue Nov 06 22:20:26 2018

Fix compile issue, typo


Reland "Update existing Switch Access tests"

This is a reland of d4860fede0e2dc63d6500f98bfe913921959c795

Original change's description:
> Update existing Switch Access tests
>
> Bug: 897365
> Change-Id: Ic8ff1ea5511f3d6cc907a880fffdffa7c5fdbcc9
> Reviewed-on: https://chromium-review.googlesource.com/c/1306787
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605719}

Bug: 897365
Change-Id: Ic0b73345f79bf5a075fd42cbea69a74b0e890257
Reviewed-on: https://chromium-review.googlesource.com/c/1320027
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Zach Helfinstein <zhelfins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605844}
[modify] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[add] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_test.extjs
[delete] https://crrev.com/65b6625b1b5e00fec90d4e1d6708196d4f18aeba/chrome/browser/resources/chromeos/switch_access/auto_scan_manager_unittest.gtestjs
[modify] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/switch_access.js
[add] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/switch_access_predicate.js
[add] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_test.extjs
[delete] https://crrev.com/65b6625b1b5e00fec90d4e1d6708196d4f18aeba/chrome/browser/resources/chromeos/switch_access/switch_access_predicate_unittest.gtestjs
[delete] https://crrev.com/65b6625b1b5e00fec90d4e1d6708196d4f18aeba/chrome/browser/resources/chromeos/switch_access/test_support.js
[modify] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/chrome/test/BUILD.gn
[modify] https://crrev.com/b159c717a1a33f5cb7bf65817383a8062f67b7d8/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter

Comment 5 by anastasi@google.com, Nov 26

Owner: anastasi@google.com
Status: Started (was: Assigned)

Comment 6 by anastasi@google.com, Nov 29

Blocking: 593885
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc20b48bed57084acab94698ddef86a672182c1a

commit dc20b48bed57084acab94698ddef86a672182c1a
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Tue Dec 04 18:20:46 2018

Add test for Switch Access Navigation Manager

Bug: 897365
Change-Id: Ib0ff177788798706ec7f05111208f61c9946a7fb
Reviewed-on: https://chromium-review.googlesource.com/c/1356002
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613607}
[modify] https://crrev.com/dc20b48bed57084acab94698ddef86a672182c1a/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[add] https://crrev.com/dc20b48bed57084acab94698ddef86a672182c1a/chrome/browser/resources/chromeos/switch_access/navigation_manager_test.extjs
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c52cbb6f58874aac4f4b5369856af106c69fd47

commit 5c52cbb6f58874aac4f4b5369856af106c69fd47
Author: Ovidio Henriquez <odejesush@chromium.org>
Date: Tue Dec 04 19:30:17 2018

Revert "Add test for Switch Access Navigation Manager"

This reverts commit dc20b48bed57084acab94698ddef86a672182c1a.

Reason for revert: linux-chromeos-rel fails the following tests:
* SwitchAccessNavigationManagerTest.MoveBackward
* SwitchAccessNavigationManagerTest.MoveBackAndForth

Bug:  911746 

Original change's description:
> Add test for Switch Access Navigation Manager
> 
> Bug: 897365
> Change-Id: Ib0ff177788798706ec7f05111208f61c9946a7fb
> Reviewed-on: https://chromium-review.googlesource.com/c/1356002
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#613607}

TBR=dtseng@chromium.org,anastasi@google.com

Change-Id: I476cc50da905be2fbfc9c75070e208575a3fa0eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897365
Reviewed-on: https://chromium-review.googlesource.com/c/1361656
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613638}
[modify] https://crrev.com/5c52cbb6f58874aac4f4b5369856af106c69fd47/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[delete] https://crrev.com/a0f2d87555e1357e9c43378e45ec0ebebda97232/chrome/browser/resources/chromeos/switch_access/navigation_manager_test.extjs
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c0cf6a74f537accd56defe2258e2cd8c9c1c18c

commit 0c0cf6a74f537accd56defe2258e2cd8c9c1c18c
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Wed Dec 05 22:53:42 2018

Add Switch Access navigation manager test

Cause of flakiness was identified to be mismatch of strings due to one
being URL-encoded.

Bug: 897365
Change-Id: Ia284819dd930ae7663e8c9f56e323412d58f4249
Reviewed-on: https://chromium-review.googlesource.com/c/1362465
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614150}
[modify] https://crrev.com/0c0cf6a74f537accd56defe2258e2cd8c9c1c18c/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[add] https://crrev.com/0c0cf6a74f537accd56defe2258e2cd8c9c1c18c/chrome/browser/resources/chromeos/switch_access/navigation_manager_test.extjs
[modify] https://crrev.com/0c0cf6a74f537accd56defe2258e2cd8c9c1c18c/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4311aa34b7cf6b363e52085263fbad88f3ddf5f

commit e4311aa34b7cf6b363e52085263fbad88f3ddf5f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Dec 14 01:04:10 2018

Disable SwitchAccessAutoScanManagerTest for Mash

This feature does not work in Mash yet.

Bug: 897365
Change-Id: I193b892afccdceb17736a1c71b3794cdad2320b6
Reviewed-on: https://chromium-review.googlesource.com/c/1377334
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616535}
[modify] https://crrev.com/e4311aa34b7cf6b363e52085263fbad88f3ddf5f/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1319d0626d45603c40ea253b329fdbff4eae77

commit 7a1319d0626d45603c40ea253b329fdbff4eae77
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Dec 14 19:07:44 2018

Disable interactive_ui_tests: SwitchAccessTest for Mash

This feature does not work in Mash yet.

Bug: 897365
Change-Id: I1fe5bb6436a4df340ab093089f8eaf0139876da4
Reviewed-on: https://chromium-review.googlesource.com/c/1377377
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616777}
[modify] https://crrev.com/7a1319d0626d45603c40ea253b329fdbff4eae77/testing/buildbot/filters/chromeos.mash.fyi.interactive_ui_tests.filter
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79c15076cce07cf978077fd2b4a678ac2e3a372f

commit 79c15076cce07cf978077fd2b4a678ac2e3a372f
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Thu Dec 27 04:56:49 2018

Revert "Add tests for the Switch Access Context Menu Manager."

This reverts commit cd1212c4c748abc80f962096917396a5250d6eae.

Reason for revert: SwitchAccessContextMenuManagerTest.* (browser_tests) failing on multiple builders

Bug: 917943

Original change's description:
> Add tests for the Switch Access Context Menu Manager.
> 
> Bug: 897365
> Change-Id: I88d67af284758498126b697e54d03fa33a1d95a5
> Reviewed-on: https://chromium-review.googlesource.com/c/1372034
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618979}

TBR=katie@chromium.org,anastasi@google.com

Change-Id: Ia9ceffe53f0aecef230695c0e4900a86e80e45b5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897365
Reviewed-on: https://chromium-review.googlesource.com/c/1390781
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619005}
[modify] https://crrev.com/79c15076cce07cf978077fd2b4a678ac2e3a372f/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[modify] https://crrev.com/79c15076cce07cf978077fd2b4a678ac2e3a372f/chrome/browser/resources/chromeos/switch_access/context_menu_manager.js
[delete] https://crrev.com/575b0e2496dec21d4a5b498d533b1945052fecdc/chrome/browser/resources/chromeos/switch_access/context_menu_manager_test.extjs
[modify] https://crrev.com/79c15076cce07cf978077fd2b4a678ac2e3a372f/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/79c15076cce07cf978077fd2b4a678ac2e3a372f/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e66ed8e69673529de5b644b06e3ed81520bc10

commit 76e66ed8e69673529de5b644b06e3ed81520bc10
Author: Anastasia Helfinstein <anastasi@google.com>
Date: Tue Jan 15 23:53:32 2019

Reland "Add tests for the Switch Access Context Menu Manager."

This is a reland of cd1212c4c748abc80f962096917396a5250d6eae

I have disabled these tests on debug builds because the childrenChanged
event that should fire when the context menu is ready does not, so the
tests hang.

Original change's description:
> Add tests for the Switch Access Context Menu Manager.
>
> Bug: 897365
> Change-Id: I88d67af284758498126b697e54d03fa33a1d95a5
> Reviewed-on: https://chromium-review.googlesource.com/c/1372034
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: Katie Dektar <katie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618979}

Bug: 897365
Change-Id: Ic5a99f4d52b4af5eea8ba920502f21aa1f5c95a0
Reviewed-on: https://chromium-review.googlesource.com/c/1401501
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622878}
[modify] https://crrev.com/76e66ed8e69673529de5b644b06e3ed81520bc10/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[modify] https://crrev.com/76e66ed8e69673529de5b644b06e3ed81520bc10/chrome/browser/resources/chromeos/switch_access/menu_manager.js
[add] https://crrev.com/76e66ed8e69673529de5b644b06e3ed81520bc10/chrome/browser/resources/chromeos/switch_access/menu_manager_test.extjs
[modify] https://crrev.com/76e66ed8e69673529de5b644b06e3ed81520bc10/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/76e66ed8e69673529de5b644b06e3ed81520bc10/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b

commit 7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b
Author: Timothy Loh <timloh@chromium.org>
Date: Wed Jan 16 05:59:31 2019

Revert "Reland "Add tests for the Switch Access Context Menu Manager.""

This reverts commit 76e66ed8e69673529de5b644b06e3ed81520bc10.

Reason for revert: SwitchAccessMenuManagerTest.NavigationInMenu is very flaky.

Example try job runs that failed:
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/179560
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/179561
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/179562
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/179565

Original change's description:
> Reland "Add tests for the Switch Access Context Menu Manager."
> 
> This is a reland of cd1212c4c748abc80f962096917396a5250d6eae
> 
> I have disabled these tests on debug builds because the childrenChanged
> event that should fire when the context menu is ready does not, so the
> tests hang.
> 
> Original change's description:
> > Add tests for the Switch Access Context Menu Manager.
> >
> > Bug: 897365
> > Change-Id: I88d67af284758498126b697e54d03fa33a1d95a5
> > Reviewed-on: https://chromium-review.googlesource.com/c/1372034
> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> > Reviewed-by: Katie Dektar <katie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#618979}
> 
> Bug: 897365
> Change-Id: Ic5a99f4d52b4af5eea8ba920502f21aa1f5c95a0
> Reviewed-on: https://chromium-review.googlesource.com/c/1401501
> Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622878}

TBR=dtseng@chromium.org,anastasi@google.com

Change-Id: I0b46d76550bd2aa7dd8f8499c6f29c728ebd81a7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897365
Reviewed-on: https://chromium-review.googlesource.com/c/1414392
Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623128}
[modify] https://crrev.com/7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b/chrome/browser/resources/chromeos/switch_access/BUILD.gn
[modify] https://crrev.com/7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b/chrome/browser/resources/chromeos/switch_access/menu_manager.js
[delete] https://crrev.com/8cea8062679fc61e206eca3bfb8eb5ea08ddfc99/chrome/browser/resources/chromeos/switch_access/menu_manager_test.extjs
[modify] https://crrev.com/7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b/chrome/browser/resources/chromeos/switch_access/switch_access_e2e_test_base.js
[modify] https://crrev.com/7eb20b85ed9278223f3e9ccb26ec5be8112fdb5b/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
►

Sign in to add a comment