New issue
Advanced search Search tips

Issue 897312 link

Starred by 5 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Bluetooth scanning

Project Member Reported by dxie@google.com, Oct 19

Issue description

Labels: Proj-Fugu
Labels: Type-Feature
Components: Blink>Bluetooth
Description: Show this description
Status: Available (was: Untriaged)
Labels: Pri-3
Owner: dougt@chromium.org
Status: Started (was: Available)
Cc: tsteiner@google.com
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23a658b9e59a3b170184bc17f2de97cdb1f225ec

commit 23a658b9e59a3b170184bc17f2de97cdb1f225ec
Author: Doug Turner <dougt@chromium.org>
Date: Thu Dec 20 01:57:54 2018

WebBluetooth Scanning API

Spec: https://webbluetoothcg.github.io/web-bluetooth/scanning.html
Design Doc: https://docs.google.com/document/d/1YdjdjQxl7acSQ3EeuMVroLfVKuoGjrtig6FbjvPQ7pg/edit#heading=h.xzptrog8pyxf

Bug: 897312
Binary-Size: Increase needed to implement Web Bluetooth Scanning.
Change-Id: Ib8aa1f213a6864609facba0f5964a7e09050aecd
Reviewed-on: https://chromium-review.googlesource.com/c/1366318
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618076}
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/chrome/browser/ui/startup/bad_flags_prompt.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/child/runtime_features.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/common/bluetooth/web_bluetooth_device_id.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/common/bluetooth/web_bluetooth_device_id.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/public/common/content_switches.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/content/public/common/content_switches.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/bluetooth_device_unittest.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/test/test_bluetooth_adapter_observer.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/device/bluetooth/test/test_bluetooth_adapter_observer.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/public/platform/web_runtime_features.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/core/events/event_type_names.json5
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/BUILD.gn
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth.h
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth.idl
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.cc
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.h
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.idl
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event_init.idl
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_device.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_device.h
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.cc
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.h
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.idl
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan_options.idl
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_manufacturer_data_map.cc
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_manufacturer_data_map.h
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_manufacturer_data_map.idl
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_service_data_map.cc
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_service_data_map.h
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/bluetooth_service_data_map.idl
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/bluetooth/navigator_bluetooth.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/event_target_modules_names.json5
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/modules/modules_idl_files.gni
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/renderer/platform/runtime_enabled_features.json5
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/bluetooth/requestLEScan/basic-scan.https.html
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/bluetooth/requestLEScan/doesnt-consume-user-gesture.https.html
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/bluetooth/requestLEScan/le-not-supported.https.html
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/bluetooth/requestLEScan/multiple-scan.https.html
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/bluetooth/requestLEScan/radio-not-present.https.html
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/external/wpt/bluetooth/idl/idlharness.tentative.https.window-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/external/wpt/bluetooth/resources/bluetooth-helpers.js
[add] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/external/wpt/bluetooth/resources/bluetooth-scanning-helpers.js
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/platform/mac/virtual/stable/webexposed/global-interface-listing-platform-specific-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/virtual/user-activation-v2/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/virtual/user-activation-v2/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/third_party/blink/web_tests/webexposed/global-interface-listing-platform-specific-expected.txt
[modify] https://crrev.com/23a658b9e59a3b170184bc17f2de97cdb1f225ec/tools/metrics/histograms/enums.xml

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b426ad5adfce85dfec8c385734916c20b8df4210

commit b426ad5adfce85dfec8c385734916c20b8df4210
Author: Doug Turner <dougt@chromium.org>
Date: Fri Dec 21 22:36:25 2018

Bluetooth - Scanning clients should use AssociatedInterfacePtrSet

Bug: 897312
Change-Id: Ia5f70cc255b7e2a537e89a20fffa8b93f1305b68
Reviewed-on: https://chromium-review.googlesource.com/c/1388214
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618640}
[modify] https://crrev.com/b426ad5adfce85dfec8c385734916c20b8df4210/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/b426ad5adfce85dfec8c385734916c20b8df4210/content/browser/bluetooth/web_bluetooth_service_impl.h

Hi there,

Have there been any security or privacy reviews of this feature so far? The spec and DD cover several interesting privacy considerations, but the implementation could probably use some attention from Security folks (specifically, the permission aspect and the possible restriction to foreground focused windows). 

Cheers,
-Artur
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c677e6c663c418b026d8b19078f900378a5c828d

commit c677e6c663c418b026d8b19078f900378a5c828d
Author: Doug Turner <dougt@chromium.org>
Date: Thu Jan 03 20:35:42 2019

WebBluetooth Scanning - DCHECK if ExecutionContext is null.

Bug: 897312
Change-Id: I3f156092b1d5687fce06ef05b2f6cf4db1d9ba32
Reviewed-on: https://chromium-review.googlesource.com/c/1388809
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619741}
[modify] https://crrev.com/c677e6c663c418b026d8b19078f900378a5c828d/third_party/blink/renderer/modules/bluetooth/bluetooth.cc

+1 to comment #12. This would benefit from privacy and security reviews. Please run this through the Chrome internal launch process too.

Comment 15 Deleted

Cc: dominickn@chromium.org
We will work with the privacy and security teams to review this feature.  Currently this web API is experimental, requires a command line to work, and displays a warning to the user that they are using a unsafe command line.

We will keep this API behind a command line and warning until the privacy and security reviews are complete and feedback is incorporated into the design and implementation.

Adding dominickn who has been thinking about fugu.
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e9cf7ad440386e4197cad3de78d132a151d91b0

commit 4e9cf7ad440386e4197cad3de78d132a151d91b0
Author: Doug Turner <dougt@chromium.org>
Date: Tue Jan 08 00:33:18 2019

bluetooth.requestLEScan() needs to pass acceptAllAdvertisements

Bug: 897312
Change-Id: Icde3beafa47d832bc08ec8ae3c7a0e207b80e699
Reviewed-on: https://chromium-review.googlesource.com/c/1393404
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620550}
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/bluetooth/requestLEScan/basic-scan.https.html
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/bluetooth/requestLEScan/doesnt-consume-user-gesture.https.html
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/bluetooth/requestLEScan/le-not-supported.https.html
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/bluetooth/requestLEScan/multiple-scan.https.html
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/bluetooth/requestLEScan/radio-not-present.https.html
[modify] https://crrev.com/4e9cf7ad440386e4197cad3de78d132a151d91b0/third_party/blink/web_tests/external/wpt/bluetooth/resources/bluetooth-helpers.js

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03c190c7f46227b627a6d9bceea854ff0b079383

commit 03c190c7f46227b627a6d9bceea854ff0b079383
Author: Doug Turner <dougt@chromium.org>
Date: Tue Jan 08 02:46:36 2019

Make BluetoothAdvertisingEvent attributes optional

This CL changes rssi, tx_power, and appearance to be optional. Note that
mojo doesn't provide automagical seralization of primative types, so we
need to add bools to convey if the value should be used and manually
construct base::Optional values.

Bug: 897312
Change-Id: I4c2fe285cfda997e442a286b9785b1149430f017
Reviewed-on: https://chromium-review.googlesource.com/c/1388385
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Doug Turner <dougt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620590}
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/device/bluetooth/bluetooth_adapter.h
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/device/bluetooth/bluetooth_adapter_mac.mm
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/device/bluetooth/test/fake_central.cc
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/device/bluetooth/test/test_bluetooth_adapter_observer.cc
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/device/bluetooth/test/test_bluetooth_adapter_observer.h
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/third_party/blink/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.cc
[modify] https://crrev.com/03c190c7f46227b627a6d9bceea854ff0b079383/third_party/blink/renderer/modules/bluetooth/bluetooth_advertising_event.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e

commit 9b931de8b79b3afeeb1ac269b4a43a8aac2a312e
Author: Doug Turner <dougt@chromium.org>
Date: Tue Jan 08 18:22:37 2019

WebBluetooth - Plumb scan options from blink to content.

This CL creates a object that holds both the scan client associated ptr
and it's related scan options in content/browser. This will be used for
filtering in a followup CL.

Bug: 897312
Change-Id: I20b3e23054dd3b34014fb934d6c54c27c381cb2a
Reviewed-on: https://chromium-review.googlesource.com/c/1393405
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620801}
[modify] https://crrev.com/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e/third_party/blink/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/9b931de8b79b3afeeb1ac269b4a43a8aac2a312e/third_party/blink/renderer/modules/bluetooth/bluetooth.cc

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3a4541036e8ceb76ec39c584b50462482355b3f

commit a3a4541036e8ceb76ec39c584b50462482355b3f
Author: Doug Turner <dougt@chromium.org>
Date: Fri Jan 11 04:41:08 2019

WebBluetooth Scanning - Add filtering support to requestLEScan()

This CL adds support for name, name prefix, and uuid services filtering.
Filtering for manufacturer data and service data will be done in a
follow up CL when crbug.com/707635 is fixed.

Bug: 897312
Change-Id: I07b221f8cc33fdcd6698c7d133b0363c58e1ea65
Reviewed-on: https://chromium-review.googlesource.com/c/1396491
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621907}
[modify] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/content/browser/bluetooth/web_bluetooth_service_impl.cc
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/accept-all-with-filter-throws.https.html
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-multiple-filters.https.html
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-and-uuid-filter.https.html
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-filter.https.html
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-prefix-filter.https.html
[add] https://crrev.com/a3a4541036e8ceb76ec39c584b50462482355b3f/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-service-uuid-filter.https.html

Cc: engedy@chromium.org
+engedy@. This is an interesting one that will probably take a little bit of thought to get the correct balance between security/privacy and ergonomics in the access model.
Project Member

Comment 22 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd10406e0f3e560ee283f3b2058751dee3adf0a7

commit cd10406e0f3e560ee283f3b2058751dee3adf0a7
Author: Doug Turner <dougt@chromium.org>
Date: Fri Jan 11 05:26:04 2019

WebBluetooth: Forward scan option values


This CL forwards the correct scan option values for
acceptAllAdvertisements and keepRepeatedDevices.

Bug: 897312
Change-Id: I62a7db6f495cf07da3478ff8b9e4291ee7b7b92c
Reviewed-on: https://chromium-review.googlesource.com/c/1401364
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ovidio Henriquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621916}
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/public/platform/modules/bluetooth/web_bluetooth.mojom
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/renderer/modules/bluetooth/bluetooth.cc
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/renderer/modules/bluetooth/bluetooth.h
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.cc
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.h
[modify] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/web_tests/bluetooth/requestLEScan/basic-scan.https.html
[add] https://crrev.com/cd10406e0f3e560ee283f3b2058751dee3adf0a7/third_party/blink/web_tests/bluetooth/requestLEScan/scan-options.https.html

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f035355ed1447471a77500ab97e5659192cf3c3c

commit f035355ed1447471a77500ab97e5659192cf3c3c
Author: Doug Turner <dougt@chromium.org>
Date: Tue Jan 15 04:37:14 2019

WebBluetooth - Implement BluetoothLEScan::filters

This enables the result of requestLEScan() to recall what filter options
were applied.

Bug: 897312
Change-Id: I9e0d626acfe220e71d8be38d944a5c6ff58f35ae
Reviewed-on: https://chromium-review.googlesource.com/c/1408222
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622733}
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/renderer/modules/bluetooth/bluetooth_le_scan.cc
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/multiple-scan.https.html
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/scan-options.https.html
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-and-uuid-filter.https.html
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-filter.https.html
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-name-prefix-filter.https.html
[modify] https://crrev.com/f035355ed1447471a77500ab97e5659192cf3c3c/third_party/blink/web_tests/bluetooth/requestLEScan/scan-with-service-uuid-filter.https.html

Project Member

Comment 24 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10051dfc9a7ae9a9534a238ea46748230b43f370

commit 10051dfc9a7ae9a9534a238ea46748230b43f370
Author: Doug Turner <dougt@chromium.org>
Date: Thu Jan 17 02:21:55 2019

WebBluetooth - Scanning should use the same device id hashing as Gatt.

This CL adds a new method to WebBluetoothDeviceId which allows us to
create a device id from a device address without adding any services
which allows scanning to share the same device address -> device id
origin specific mapping.

Bug: 897312
Change-Id: Ib3dda1c2d47138486c1457eb25a8dc602b52e2f0
Reviewed-on: https://chromium-review.googlesource.com/c/1405368
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623520}
[modify] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/content/browser/bluetooth/bluetooth_allowed_devices.cc
[modify] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/content/browser/bluetooth/bluetooth_allowed_devices.h
[modify] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/content/common/bluetooth/web_bluetooth_device_id.cc
[modify] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/content/common/bluetooth/web_bluetooth_device_id.h
[add] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/third_party/blink/web_tests/bluetooth/requestLEScan/attempt-to-connect-after-scan.https.html
[add] https://crrev.com/10051dfc9a7ae9a9534a238ea46748230b43f370/third_party/blink/web_tests/bluetooth/requestLEScan/device-ids-match.https.html

Sign in to add a comment