New issue
Advanced search Search tips

Issue 897266 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Avoid handling gms client tasks on the UI thread

Project Member Reported by tobiasjs@chromium.org, Oct 19

Issue description

See internal bug b/116829436

GoogleApiClient.Builder.setHandler() doesn't set the handler used only for calling supplied callbacks; it's used for processing binder calls, and this can lead to the propagation of strict mode violations.
 
This probably needs fixing for all the non-webview usage as well, even though I don't think those callers use setHandler, because the default handler is the UI thread anyway and so the callers that don't call it are also broken.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94e4c7f3f420d0dc1437a6b6a0d0a4e11831df3a

commit 94e4c7f3f420d0dc1437a6b6a0d0a4e11831df3a
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Mon Oct 22 19:19:23 2018

[aw] Provide a Handler on which platform service tasks can execute

Bug:  897266 
Change-Id: Icc0f7b1671031f76e2781ed2e6e217c50f0925e6
Reviewed-on: https://chromium-review.googlesource.com/c/1292469
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601676}
[modify] https://crrev.com/94e4c7f3f420d0dc1437a6b6a0d0a4e11831df3a/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/a3c1c2160ab48dad586d452ebd4a4dd354c073a8

commit a3c1c2160ab48dad586d452ebd4a4dd354c073a8
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Wed Oct 24 20:26:46 2018

Labels: Merge-Request-71
This wants to be merged to M71 so we can test it doesn't break things in beta.
Cc: benmason@chromium.org torne@chromium.org
Owner: torne@chromium.org
Status: Started (was: Assigned)
I'm going to do the merges etc. This should be fixed on 72 now.
Per the internal bug, the CTS test failure is hard to repro (we're not sure what the preconditions are for it to fail) so this may be hard to verify; the plan is to merge the fix to 71 and look at the results after 71 is dropped into internal master.
Project Member

Comment 8 by sheriffbot@chromium.org, Oct 25

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-71 Merge-Approved-71
Merge approved to 71, branch 3578.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 30

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/443d85341601397f7f97c990aaf5ec052127448b

commit 443d85341601397f7f97c990aaf5ec052127448b
Author: Torne (Richard Coles) <torne@google.com>
Date: Tue Oct 30 17:41:55 2018

[aw] Provide a Handler on which platform service tasks can execute

TBR=tobiasjs@google.com

(cherry picked from commit 94e4c7f3f420d0dc1437a6b6a0d0a4e11831df3a)

Bug:  897266 
Change-Id: Icc0f7b1671031f76e2781ed2e6e217c50f0925e6
Reviewed-on: https://chromium-review.googlesource.com/c/1292469
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601676}
Reviewed-on: https://chromium-review.googlesource.com/c/1308039
Cr-Commit-Position: refs/branch-heads/3578@{#404}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/443d85341601397f7f97c990aaf5ec052127448b/android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/443d85341601397f7f97c990aaf5ec052127448b

Commit: 443d85341601397f7f97c990aaf5ec052127448b
Author: torne@google.com
Commiter: torne@chromium.org
Date: 2018-10-30 17:41:55 +0000 UTC

[aw] Provide a Handler on which platform service tasks can execute

TBR=tobiasjs@google.com

(cherry picked from commit 94e4c7f3f420d0dc1437a6b6a0d0a4e11831df3a)

Bug:  897266 
Change-Id: Icc0f7b1671031f76e2781ed2e6e217c50f0925e6
Reviewed-on: https://chromium-review.googlesource.com/c/1292469
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601676}
Reviewed-on: https://chromium-review.googlesource.com/c/1308039
Cr-Commit-Position: refs/branch-heads/3578@{#404}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Status: Fixed (was: Started)
Cc: ntfschr@chromium.org tobiasjs@chromium.org
Torne, did you merge http://crrev/i/701668? I can't find the downstream release branch.
Whoops, no I didn't. I'll do it now.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/27db72e424280d6adb3facd61c07276284f3d1c3

commit 27db72e424280d6adb3facd61c07276284f3d1c3
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Wed Oct 31 15:07:21 2018

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 1

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/5d27fcc88f037a91c680b9a7707d2f46059df04c

commit 5d27fcc88f037a91c680b9a7707d2f46059df04c
Author: Tobias Sargeant <tobiasjs@google.com>
Date: Thu Nov 01 09:03:10 2018

Cc: vakh@chromium.org
vakh@ may be interested in this. This is specific to connection-based APIs, but connectionless APIs may have similar gotchas.
Please add QA Manual verificato0n steps to be verified on M71

Sign in to add a comment