New issue
Advanced search Search tips

Issue 897264 link

Starred by 1 user
Status: Fixed
Owner:
davidben@chromium.org
Closed: Oct 23
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

PKCS#12 import does not focus the password field

Project Member Reported by davidben@chromium.org, Oct 19 
Chrome Version: 69.0.3497.100 (Official Build) (64-bit)
OS: gLinux

What steps will reproduce the problem?
(1) Go to chrome://settings/certificates
(2) Press IMPORT
(3) Select a PKCS#12 file, e.g. net/data/ssl/certificates/client.p12 from Chromium

What is the expected result?
The "Enter your certificate password" prompt appears with the text field focused.

What happens instead?
The prompt appears, but the text field is not focused.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by davidben@chromium.org, Oct 19

Owner: davidben@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromium/src/+/1292603
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93d6b797abc38648cdf1320fa20f7823b5b9b53d

commit 93d6b797abc38648cdf1320fa20f7823b5b9b53d
Author: David Benjamin <davidben@chromium.org>
Date: Tue Oct 23 21:52:36 2018

Auto-focus certificate import/export password fields.

Test: 1. Go to chrome://settings/certificates
      2. Press IMPORT
      3. Select a PKCS#12 file, e.g.
	 net/data/ssl/certificates/client.p12 from Chromium (password is
	 "12345")
      4. FIX #1: Password dialog should focus the input field.
      5. Type the password and import.
      6. Expand the entry for the newly-imported certificate. Hit
         the "..." button and select "Export".
      7. Pick some file to export it to.
      8. FIX #2: Password dialog should focus the first input field.

Bug:  897264 
Change-Id: Ia9377d9c776e486c6745cc32e3228193c1a265b6
Reviewed-on: https://chromium-review.googlesource.com/c/1292603
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602117}
[modify] https://crrev.com/93d6b797abc38648cdf1320fa20f7823b5b9b53d/ui/webui/resources/cr_components/certificate_manager/certificate_password_decryption_dialog.html
[modify] https://crrev.com/93d6b797abc38648cdf1320fa20f7823b5b9b53d/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.html

Comment 3 by davidben@chromium.org, Oct 23

Status: Fixed (was: Started)
►

Sign in to add a comment