Content settings get disabled when entering their sub page. |
|||||||||
Issue descriptionChrome Version: Linux: 72.0.3586.0 (Developer Build) (64-bit) Windows: 72.0.3585.1 (Official Build) canary-dcheck (32-bit) (cohort: ASAN) OS: Linux, Windows, possibly the other desktop OSes What steps will reproduce the problem? (1) Navigate to chrome://settings/content (2) Notice that for most settings, the default is Allow/Ask. Select a content setting to enter its submenu. (3) Notice that the setting is Disabled/Blocked when entering the menu. What is the expected result? Entering the content setting submenu should not modify the setting. What happens instead? Entering the content setting submenu modifies the setting. If you go back to the previous page and enter the same menu, it does not modify the setting anymore. However, if you refresh the page, the first time that you enter a setting sub menu, its value will be set to Disabled/Blocked. I've tested this on other versions of Chrome and OSes. This doesn't happen for the following Chrome and OS combinations: * ChromeOS * 71.0.3578.8 (Official build) dev (64-bit) * Linux * 70.0.3538.67 (Official build) (64-bit) * 70.0.3538.67 (Official build) beta (64-bit) * 71.0.3578.10 (Official build) dev (64-bit) * Windows * 70.0.3538.67 (Official build) (64-bit) (cohort: 70_67_Win) * 70.0.3538.67 (Official build) beta (64-bit) (cohort: Beta) * 71.0.3578.10 (Official build) dev (64-bit) (cohort: Dev) So it recently started happening in 72.
,
Oct 23
,
Oct 23
I am able reproduce this.
,
Oct 23
The issue seems to be happening because of Polymer observer behavior changes in Polymer 2. Still investigating...
,
Oct 23
Candidate fix at https://chromium-review.googlesource.com/c/chromium/src/+/1297231.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6d635342689e2b9c2cbe19cf29d5c059b9c4131 commit d6d635342689e2b9c2cbe19cf29d5c059b9c4131 Author: dpapad <dpapad@chromium.org> Date: Tue Oct 23 22:33:08 2018 Settings WebUI: Fix default setting for content exceptions. Because of Polymer 2's different observer dependencies semantics the default setting was erroneously toggled when the user enter the subpage. Bug: 897236 Change-Id: I83b8959734e85d39e35f0acd187062326143b876 Reviewed-on: https://chromium-review.googlesource.com/c/1297231 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602142} [modify] https://crrev.com/d6d635342689e2b9c2cbe19cf29d5c059b9c4131/chrome/browser/resources/settings/site_settings/category_default_setting.js [modify] https://crrev.com/d6d635342689e2b9c2cbe19cf29d5c059b9c4131/chrome/test/data/webui/settings/category_default_setting_tests.js
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6d635342689e2b9c2cbe19cf29d5c059b9c4131 commit d6d635342689e2b9c2cbe19cf29d5c059b9c4131 Author: dpapad <dpapad@chromium.org> Date: Tue Oct 23 22:33:08 2018 Settings WebUI: Fix default setting for content exceptions. Because of Polymer 2's different observer dependencies semantics the default setting was erroneously toggled when the user enter the subpage. Bug: 897236 Change-Id: I83b8959734e85d39e35f0acd187062326143b876 Reviewed-on: https://chromium-review.googlesource.com/c/1297231 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602142} [modify] https://crrev.com/d6d635342689e2b9c2cbe19cf29d5c059b9c4131/chrome/browser/resources/settings/site_settings/category_default_setting.js [modify] https://crrev.com/d6d635342689e2b9c2cbe19cf29d5c059b9c4131/chrome/test/data/webui/settings/category_default_setting_tests.js
,
Oct 23
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by csharrison@chromium.org
, Oct 19