Permission bubble location is not updated going into tablet mode |
||||
Issue descriptionWhen the browser location bar is showing a permission bubble, and we switch to tablet mode, the layout of the browser is changed, but the permission bubble remains where it was. See attached video.
,
Oct 23
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/434172893d757d157c80c93f9b40b1181b432a08 commit 434172893d757d157c80c93f9b40b1181b432a08 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Thu Oct 25 20:15:08 2018 [Merge to M-71] Fix browser permission bubble positioning This CL fixes two issues regarding the browser permission bubble dialogs: - Switching in / out of tablet mode changes the browser top controls size, and position. If a permission bubble is shown, its position will be broken. - We should not allow top-chrome to hide while a permission bubble is visible, not until the user dismisses it. TBR=sky@chromium.org, timloh@chromium.org BUG=896970, 897227 TEST=Added new browser test. Change-Id: I979fe067531811165b5443f6f28c922c74251e21 Reviewed-on: https://chromium-review.googlesource.com/c/1292720 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601971}(cherry picked from commit 47f2f5286b6e7a0d715bfb6cf563d26fefd5fe80) Reviewed-on: https://chromium-review.googlesource.com/c/1299921 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#334} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/434172893d757d157c80c93f9b40b1181b432a08/chrome/browser/permissions/permission_request_manager.cc [modify] https://crrev.com/434172893d757d157c80c93f9b40b1181b432a08/chrome/browser/permissions/permission_request_manager.h [modify] https://crrev.com/434172893d757d157c80c93f9b40b1181b432a08/chrome/browser/ui/views/frame/browser_view.cc [modify] https://crrev.com/434172893d757d157c80c93f9b40b1181b432a08/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc [modify] https://crrev.com/434172893d757d157c80c93f9b40b1181b432a08/chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos_browsertest.cc
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/434172893d757d157c80c93f9b40b1181b432a08 Commit: 434172893d757d157c80c93f9b40b1181b432a08 Author: afakhry@chromium.org Commiter: afakhry@chromium.org Date: 2018-10-25 20:15:08 +0000 UTC [Merge to M-71] Fix browser permission bubble positioning This CL fixes two issues regarding the browser permission bubble dialogs: - Switching in / out of tablet mode changes the browser top controls size, and position. If a permission bubble is shown, its position will be broken. - We should not allow top-chrome to hide while a permission bubble is visible, not until the user dismisses it. TBR=sky@chromium.org, timloh@chromium.org BUG=896970, 897227 TEST=Added new browser test. Change-Id: I979fe067531811165b5443f6f28c922c74251e21 Reviewed-on: https://chromium-review.googlesource.com/c/1292720 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601971}(cherry picked from commit 47f2f5286b6e7a0d715bfb6cf563d26fefd5fe80) Reviewed-on: https://chromium-review.googlesource.com/c/1299921 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#334} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Oct 23