New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897226 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Proj-Fingerprints



Sign in to add a comment

Refactor fingerprint mojom

Project Member Reported by jdufault@chromium.org, Oct 19

Issue description

Some of the fingerprint mojoms are not strongly typed, or have confusing semantics.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/947f24700d11b904cabf0ece373ae5f5c710e23b

commit 947f24700d11b904cabf0ece373ae5f5c710e23b
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Oct 24 21:08:16 2018

cros: Simplify fingerprint mojom between ash and chrome

- Renamed FingerprintUnlockState to FingerprintState
- FingerprintState no longer has AUTH_FAILED and AUTH_SUCCESS. FingerprintState
  instead determines if fingerprint is enabled. A seperate mojom method is used
  to notify the ash that an authentication attempt has taken place.
- Reordered fingerprint mojom method so it is next to PIN
- Eliminated ScreenLocker::FingerprintState, which duplicated the mojom type
- Fixed a bug in screen_locker.cc where timing out PIN depended on fingerprint
  being enabled.
- Backlights being forced off is now reset only after an authentication attempt.
  This means that fingerprint timing out will not turn the display on.
- Lock screen is now initialized with full fingerprint state instead of a bool.
- Renamed some methods to increase clarity

Bug: 897226
Change-Id: I841c7bbdd32730532148ddae96e1b490bee4eb0a
Reviewed-on: https://chromium-review.googlesource.com/c/1291998
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602450}
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/login_screen_controller.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/login_screen_controller.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/lock_contents_view.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/lock_contents_view_unittest.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/lock_debug_view.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/login_auth_user_view.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/login_data_dispatcher.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/login/ui/login_data_dispatcher.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/ash/public/interfaces/login_user_info.mojom
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/screen_locker.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/lock/webui_screen_locker.h
[modify] https://crrev.com/947f24700d11b904cabf0ece373ae5f5c710e23b/chrome/browser/chromeos/login/screens/user_selection_screen.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6

commit 9b0608c2e78c109fe3fedf2233c9ee73c344e2a6
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Dec 13 19:20:24 2018

cros: Strongly type int32_t types int fingerprint.mojom

Bug: 897226
Change-Id: I4a6baad5b39a76eb2e82d8e351ea8dfbd0f53438
Reviewed-on: https://chromium-review.googlesource.com/c/1292269
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616388}
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/chromeos/login/lock/screen_locker.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/chromeos/login/lock/screen_locker.h
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/ui/webui/chromeos/login/fingerprint_setup_screen_handler.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/ui/webui/chromeos/login/fingerprint_setup_screen_handler.h
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chrome/browser/ui/webui/settings/chromeos/fingerprint_handler.h
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chromeos/dbus/biod/biod_client.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chromeos/dbus/biod/biod_client.h
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chromeos/dbus/biod/biod_client_unittest.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chromeos/dbus/biod/fake_biod_client.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/chromeos/dbus/biod/fake_biod_client.h
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/services/device/fingerprint/fingerprint_chromeos.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/services/device/fingerprint/fingerprint_chromeos_unittest.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/services/device/public/mojom/fingerprint.mojom
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/ui/chromeos/user_activity_power_manager_notifier.cc
[modify] https://crrev.com/9b0608c2e78c109fe3fedf2233c9ee73c344e2a6/ui/chromeos/user_activity_power_manager_notifier.h

Sign in to add a comment