New issue
Advanced search Search tips

Issue 897219 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

improve gerrit upload output to use crrev.com for URI shortening

Project Member Reported by vapier@chromium.org, Oct 19 
today when you upload a CL, you get verbose output like:
remote: Processing changes: refs: 1, new: 1, done
remote:
remote: SUCCESS
remote:
remote: New Changes:
remote:   https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1291871 cros: support subcommands with arbitrary args

can gerrit plugins hook this message stage ?  that way we could write a gerrit plugin just for our Chrome GoB instances to change the displayed URI to use crrev.com.  so the output would be:
remote: New Changes:
remote:   https://crrev.com/c/1291871 cros: support subcommands with arbitrary args

Comment 1 by ajp@chromium.org, Oct 19

Status: Available (was: Untriaged)
This would be nice! A quick as on the Gerrit chat room indicates they would be open to accepting CLs that add the ability to do this in a plugin. 

They have recently factored out their URL generation in https://gerrit-review.googlesource.com/c/gerrit/+/195200 which would make it easier to do across the board.

Comment 2 by ajp@chromium.org, Oct 24 

Some pointers from Dave Borowitz:

http://google3/third_party/java_src/gerritcodereview/gerrit/java/com/google/gerrit/server/git/ChangeReportFormatter.java

It's a DynamicItem so designed to be swappable, but may not be now because it's unconditionally bound to the default implementation: 

http://google3/third_party/java_src/gerritcodereview/gerrit/java/com/google/gerrit/server/git/GitModule.java?l=31&rcl=191579433

contrast with e.g. LocalMergeSuperSetComputation.Module, which is not installed at all in GoB:
 
http://google3/third_party/java_src/gerritcodereview/gerrit/java/com/google/gerrit/server/submit/LocalMergeSuperSetComputation.java?l=69&rcl=217688751
►

Sign in to add a comment