New issue
Advanced search Search tips

Issue 897214 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 870116

Blocking:
issue 898270
issue 882513



Sign in to add a comment

Use SharedImageInterface to create image for ZeroCopyRasterBufferProvider

Project Member Reported by penghuang@google.com, Oct 19

Issue description

Use SharedImageInterface to create image for ZeroCopyRasterBufferProvider
 
Blockedon: 870116
Blocking: 882513
Note, we don't have GMB support in SharedImageInterface yet, but I'm working on exactly that.
Blocking: 898270
Labels: vulkanize
Labels: -vulkanize Proj-Vulkanize
Owner: piman@chromium.org
Labels: -Pri-3 Pri-1
Components: Internals>GPU>Internals
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41093c0de48270ae68cdcbbd616c4fa6c94bdba7

commit 41093c0de48270ae68cdcbbd616c4fa6c94bdba7
Author: Antoine Labour <piman@chromium.org>
Date: Wed Nov 07 23:16:16 2018

Fix texture_target_exception_list for unit tests

Previously, InProcessGpuThreadHolder initialized
texture_target_exception_list according to the production expectations,
in particular assuming native GMB types when available. However all unit
tests use viz::TestGpuMemoryBufferManager (if any GMBManager at all)
which only produces shared memory GMBs. This means the wrong target will
be used for those. It's mostly harmless on Mac
(GL_TEXTURE_RECTANGLE_ARB) but no so much on other platforms
(GL_TEXTURE_EXTERNAL_OES which doesn't allow glTex*Image*).

Instead, leave texture_target_exception_list empty, individual tests can
initialize it if they need (e.g. if they use a GpuMemoryBufferFactory).

Bug:  897214 
Change-Id: I55984ef49797fa97f00e2bda35b60a4e6ba734bc
Reviewed-on: https://chromium-review.googlesource.com/c/1322610
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606195}
[modify] https://crrev.com/41093c0de48270ae68cdcbbd616c4fa6c94bdba7/gpu/ipc/BUILD.gn
[modify] https://crrev.com/41093c0de48270ae68cdcbbd616c4fa6c94bdba7/gpu/ipc/client/raster_in_process_context_tests.cc
[modify] https://crrev.com/41093c0de48270ae68cdcbbd616c4fa6c94bdba7/gpu/ipc/in_process_gpu_thread_holder.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5a2101affba7a813731b399a9e102b86a7f27c6

commit e5a2101affba7a813731b399a9e102b86a7f27c6
Author: Antoine Labour <piman@chromium.org>
Date: Wed Nov 07 23:36:27 2018

Use SharedImageInterface in ZeroCopyRasterBufferProvider

Bug:  882513 ,  897214 
Change-Id: I3d7dc804db292b7a9844eda856195b7b7b1450d3
Reviewed-on: https://chromium-review.googlesource.com/c/1316347
Commit-Queue: Antoine Labour <piman@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606210}
[modify] https://crrev.com/e5a2101affba7a813731b399a9e102b86a7f27c6/cc/raster/zero_copy_raster_buffer_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment