Print Preview - Save to Google Drive option causes content to show in greyscale |
|||||||||
Issue descriptionChrome version: 69.0.3497.120 (Official Build) (64-bit) Platform: 10895.78.0 (Official Build) stable-channel zako OS version: Issue happens regardless of the OS. So far it has been reproduced in Windows, Mac and Chrome OS. Case#: 17237921 Description: When printing content from any site and choosing the option to save to Google Drive, the print preview shows in greyscale, even if the content has different colors. When saving the content, it shows in color. Video of the issue: https://drive.google.com/open?id=1_DQaTk59K-Jj3nicTCBdgKyhglMNCVZZ Steps to reproduce: Print any content from Chrome and choose the option to Save to Google Drive. Issue can be reproduced by different users and on different environments, but it seems it only affects the option to save to Drive. Current Behavior / Reproduction: Print preview shows content in greyscale Expected Behavior: Print preview should show content with original colors. Drive link to logs: N/A Issue was first noticed around October 10th 2018
,
Oct 22
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5 commit fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5 Author: rbpotter <rbpotter@chromium.org> Date: Thu Oct 25 18:31:41 2018 Print Preview: Specify unavailable color setting for Google Drive/Mobile These printers do not report accurate CDDs. Bug: 897212 Change-Id: I9edb569fb600decaa2a88bf253ad7cbc81aafa23 Reviewed-on: https://chromium-review.googlesource.com/c/1295309 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#602804} [modify] https://crrev.com/fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5/chrome/browser/resources/print_preview/new/model.js [modify] https://crrev.com/fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5/chrome/test/data/webui/print_preview/settings_section_test.js
,
Oct 25
,
Nov 9
Re-opening this to request a merge to M-71. This is a small, safe, 5 line change that is verified by automated tests, has been in Canary for over a week, and will fix a major polish issue when the new print preview rolls out in 71. Also verified this works in both Canary (72.0.3605.0) and Dev (72.0.3602.2) on Windows 10.
,
Nov 9
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 9
Approving merge to M71 branch 3578 based on comment #5, pls merge ASAP. Thank you.
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/059e96705a83c37bd4091c301bfcbbdea0eb8228 Commit: 059e96705a83c37bd4091c301bfcbbdea0eb8228 Author: rbpotter@chromium.org Commiter: rbpotter@chromium.org Date: 2018-11-09 04:57:37 +0000 UTC Print Preview: Specify unavailable color setting for Google Drive (M71) Also for mobile printers. These printers do not report accurate CDDs. TBR=dpapad@chromium.org Bug: 897212 Change-Id: I9edb569fb600decaa2a88bf253ad7cbc81aafa23 Reviewed-on: https://chromium-review.googlesource.com/c/1295309 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602804}(cherry picked from commit fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5) Reviewed-on: https://chromium-review.googlesource.com/c/1328562 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#602} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/059e96705a83c37bd4091c301bfcbbdea0eb8228 commit 059e96705a83c37bd4091c301bfcbbdea0eb8228 Author: rbpotter <rbpotter@chromium.org> Date: Fri Nov 09 04:57:37 2018 Print Preview: Specify unavailable color setting for Google Drive (M71) Also for mobile printers. These printers do not report accurate CDDs. TBR=dpapad@chromium.org Bug: 897212 Change-Id: I9edb569fb600decaa2a88bf253ad7cbc81aafa23 Reviewed-on: https://chromium-review.googlesource.com/c/1295309 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602804}(cherry picked from commit fd9df1b3fbf8df5f9cb916a8aa1e8613d0eb9dc5) Reviewed-on: https://chromium-review.googlesource.com/c/1328562 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#602} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/059e96705a83c37bd4091c301bfcbbdea0eb8228/chrome/browser/resources/print_preview/new/model.js [modify] https://crrev.com/059e96705a83c37bd4091c301bfcbbdea0eb8228/chrome/test/data/webui/print_preview/new_print_preview_ui_browsertest.js [modify] https://crrev.com/059e96705a83c37bd4091c301bfcbbdea0eb8228/chrome/test/data/webui/print_preview/settings_section_test.js
,
Nov 21
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by rbpotter@chromium.org
, Oct 22Status: Assigned (was: Untriaged)