Issue metadata
Sign in to add a comment
|
Sometimes Chinese candidate window disappear on app Launcher |
||||||||||||||||||||||
Issue descriptionChrome Version : 71.0.3578.13 Platform : 11151.6.0 - cyan What steps will reproduce the problem? 1. set IME to Pinyin input method 2. enter "ttjk" or "tianmen" on the Search field What is the expected result? The candidate window should stay until committing the input. What happens instead? The Chinese candidate window disappears. Please provide any additional information below. Attach a screenshot if possible. Unable to reproduce the issue on omnibox, Findinpage,gmail, etc... Unable to reproduce the issue on 70.0.3538.69/ 11021.51.0 -Snappy
,
Oct 23
Probably shares the same root cause as issue 897200 . Can we find owners of the App Launcher to take a look?
,
Nov 5
,
Nov 5
It's related to auto complete search, disabling #enable-app-list-search-autocomplete in chrome://flags will fix this.
,
Nov 6
shuchen@, we are calling Textfield::SetText() and Textfield::SelectRange() while you are typing Chinese. I think that's why the candidate window is canceled. One work around might be disabling auto complete search when your input method will trigger a candidate window. Do you know how to check this condition?
,
Nov 7
,
Nov 8
shuchen@ please advise
,
Nov 8
<Bulk edit> Reminder M71 Stable is approaching. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure any planned work will be tested in Beta and verified before the Stable date. Thanks
,
Nov 8
If we do not find a clean fix in the next two days (until Nov 12), we will disable autocomplete feature.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f7a616d6293adb1a33306fd3ce968181dd8e516 commit 6f7a616d6293adb1a33306fd3ce968181dd8e516 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Tue Nov 13 07:28:07 2018 Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#607515} [modify] https://crrev.com/6f7a616d6293adb1a33306fd3ce968181dd8e516/ash/public/cpp/app_list/app_list_features.cc
,
Nov 13
,
Nov 13
,
Nov 14
,
Nov 14
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1425b26fa2a308d314afa4b2891f21e5ea0e38d Commit: f1425b26fa2a308d314afa4b2891f21e5ea0e38d Author: kaznacheev@google.com Commiter: kaznacheev@chromium.org Date: 2018-11-14 15:23:41 +0000 UTC Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. TBR=kaznacheev@google.com (cherry picked from commit 6f7a616d6293adb1a33306fd3ce968181dd8e516) Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607515} Reviewed-on: https://chromium-review.googlesource.com/c/1335600 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#681} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f1425b26fa2a308d314afa4b2891f21e5ea0e38d commit f1425b26fa2a308d314afa4b2891f21e5ea0e38d Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Wed Nov 14 15:23:41 2018 Disable Launcher autocomplete by default Autocomplete breaks several features (see linked bugs) and a correct fix requires investigation. Disabling the feature for now. TBR=kaznacheev@google.com (cherry picked from commit 6f7a616d6293adb1a33306fd3ce968181dd8e516) Bug: 897206 , 902558 Test: manual Change-Id: I54a68a88541fab0e2054349c32c1c1892324f67a Reviewed-on: https://chromium-review.googlesource.com/c/1332148 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#607515} Reviewed-on: https://chromium-review.googlesource.com/c/1335600 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#681} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/f1425b26fa2a308d314afa4b2891f21e5ea0e38d/ash/public/cpp/app_list/app_list_features.cc
,
Nov 14
Disabled launcher autocomplete in ToT and M71 until this is fixed.
,
Nov 14
I'll follow up with a fix.
,
Nov 14
,
Nov 14
,
Nov 20
,
Nov 23
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58e8c480febc79862c6ca7a569a9168f5aadbede commit 58e8c480febc79862c6ca7a569a9168f5aadbede Author: Weidong Guo <weidongg@chromium.org> Date: Wed Nov 28 00:35:50 2018 Fix ime candidate window issue for autocomplete Changes: Use composition text instead of Textfield::SetText() for autocomplete text to avoid cancelling candidate popup window. Bug: 897206 Test: SearchBoxViewAutocompleteTest.SearchBoxAutocompletesNotHandledForIME Change-Id: I876aa4fd4c755b98437a28ed463a19b0e067be15 Reviewed-on: https://chromium-review.googlesource.com/c/1340831 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611459} [modify] https://crrev.com/58e8c480febc79862c6ca7a569a9168f5aadbede/ash/app_list/views/search_box_view.cc [modify] https://crrev.com/58e8c480febc79862c6ca7a569a9168f5aadbede/ash/app_list/views/search_box_view.h [modify] https://crrev.com/58e8c480febc79862c6ca7a569a9168f5aadbede/ash/app_list/views/search_box_view_unittest.cc
,
Nov 29
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shend@chromium.org
, Oct 22Status: Assigned (was: Untriaged)