Issue metadata
Sign in to add a comment
|
Omnibar color inconsistent between builds
Reported by
livefort...@gmail.com,
Oct 19
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.10 Safari/537.36 Steps to reproduce the problem: 1. Omnibar color (standard) is now suddenly forced WHITE again as of 71.0.3578.10 (Official Build) dev (64-bit) 2. Omnibar color (incognito) is now FOR THE FIRST TIME EVER now also forced WHITE as of 71.0.3578.10 (Official Build) dev (64-bit) What is the expected behavior? Omnibar has ALWAYS been dark/black as clear indication to user that they were running incognito. In prior recent DEV builds with the flag set for clamshell (NORMAL) "#top-chrome-md", even the normal-mode omnibar color was not being hard-coded (forced) as bright WHITE and took on the color of the theme set in many cases for eyesight issues/contrast etc. as in my case. So, when a dark high-contrast theme was set, the omnibar even in normal mode could be set to a dark background, very similar to the native (no theme) incognito color. What went wrong? Suddenly with 71.0.3578.10 update, the omnibar is the ONLY GUI element to change and is now bright white and is suddenly not impacted at all by Chromium theme colors as it was in prior builds. Many builds ago (DEV) there was a build or two where this same issue occurred and the bar was forced white, and was then quickly corrected a build or two later, so this must be a regression re-introduced but my concern is if proper attention and discussion does not take place, that this (erroneous) regression might become permanent which will have a major impact to those that are vision impaired (see comments section below). Did this work before? Yes 71.0.3569 (might have still been ok in 71.0.3573 cannot confirm) Chrome version: 71.0.3578.10 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: The impact of forcing the Omnibar color to such a static bright color like this is high to those of us with accessibility issues related to vision and need to use a reverse/dark theme to be able to read. The currently forced white becomes so strenuous (almost impossible) to read given my theme and forces me to have to remove my theme all together which puts anyone with vision impairment into a situation where Chrome is the only web browser not offering any vision related accessibility assistance. I would pose the question to the DEV team and whomever made this sudden change after not only the years of non-material-design but even with the new MD design all the way until this specific build (and I have searched and found no issues specific to the omnibar color being dependent/controlled by theme ever once reported in the past) - then what is the reason and benefit to doing so now when it clearly poses a negative impact to some users who need the ability to change the color for accessibility? Surely Chromium/Chrome/Google does not want Chrome to be the only web browser to not offer such simple/minimal accessibility options for vision-impaired users, given that there are only a few key GUI elements even required to accept a color change - and that had already been successfully implemented in prior versions. Thank you for looking into this!
,
Oct 19
Hi, requesting some feedback with this update. A coworker had a Win7 virtual machine so we were able to check this. On Chrome Canary, 3584, we see the Omnibox as dark. You could check if your machine is back to normal (the changes will propagate to Dev ~tuesday next week), or otherwise we can think about what the differences in setup are. Do you have a theme installed? We did not have a theme. We also had Aero enabled (win7 translucency / hardware acceleration) on, and used a normal Chrome canary. Thank you!
,
Oct 19
Also, I recognize the questions don't cover all the behaviors in the original mail. They're trying to address the "omnibox in incognito is forced white" issue first.
,
Oct 19
I was able to get a light omnibox in incognito with a theme. Tentatively assigning to UI>Themes for further investigation and triage. Still requesting feedback from filer - do you see a dark omnibox ok without themes?
,
Oct 20
No do you have the flag set for #top-chrome-md? It sure looks to me by the shape of your tabs that you do NOT have that flag set. Without that flag, it has been quite some time since it was possible at all due to the new design so that MUST be specific to WIN10. Anyway, with that flag set to "normal - for clamshell devices" ON WIN7 rather than allowing "all upcoming UI features" to force on the new design, then the color would be allowed through theming. That workaround via that flag, however, is now what (through regression I'm assuming) has broken for the 2nd time. What is very notable is that in the last single build the behavior changed forgetting themes all together in the incognito omnibar which never has themes applied, anyway. Prior DEV build, even with this flag set to normal, the omnibar was dark grey incognito. Now, suddenly even the incognito bar is white. Again - all WIN7x64 - all Chrome DEV x64. 2 weeks ago was fine now is not and broke for a couple builds exactly like this some time ago to then be corrected and I apologize for not having exact build #s for the last time as I understand how that might help narrow it down. All I can say is it was at least a handful of builds ago so a couple/few months at most. Thanks much for looking at this so quickly!
,
Oct 20
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 21
,
Oct 22
Tried checking the issue on reported chrome version 71.0.3578.10 using Windows 7 and Windows 10 with the below mentioned steps. 1. Launched Chrome 2. Opened Incognito tab Our Observations: ----------------- When a theme is added to chrome omnibar is seen in white color, without the theme the dark omnibar is seen. Similar behaviour is seen on 60.0.3112.0 This doesn't seem to be a regression as the change is seen due to the theme, hence removing Needs-Bisect label. Please add the label back if required. Requesting someone from UI>Browser>Themes team to have a look into this for further inputs.
,
Oct 22
When you install a browser theme, you give up the comprehensive incognito theming and instead get a darkened version of the normal window. Thus you lose the dark omnibox.
,
Oct 24
I'm using the most minimal dark theme named - "Morpheon Dark - Aero v1.2" - as an example which is also one of the oldest that I'm also using because it also specifically was made to fully support WIN7 Aero. I certainly don't mind trying other themes but since this theme hasn't changed nor has by extensions, yet the browser appearance has I thought it best to determine the root cause. Please note that I specifically installed an older version 1.2 of this theme because once WIN10 was released from what I can tell from unpacking, the newer versions added back in the non-aero image slice (main frame) since WIN10 obviously does not support Aero anymore. The old version I have placed here in it's original CRX form here and relies on manifest colors vs graphics for almost the entire them which makes it that much more perfect for testing: https://1drv.ms/u/s!AhSqjTYUuHPKg8UvpSthzqsUnz0X5w And everything in the manifest I can tell looks correct and either way I have not changed this theme and am suddenly having very different results specific to the omnibar and incognito without any other theme or extension changes just in the last couple/few versions of Chrome DEV. Here is a screenshot of my normal browser window with this theme (my Chrome has updated now to 71.0.3578.20 (Official Build) dev (64-bit) which is what I ran to take these screenshots today: https://imgur.com/Bc3qom5 Note I intentionally opened the "find" input as it is SUPPOSED to share the color via theme as the omnibar, as you see it USED to prior to this bug again when it worked, the omnibar held the same dark color as the find bar shown and now the find bar still is correct with the omnibar suddenly bright white. And here is an incognito window opened to google.com with the same theme in the same session: https://imgur.com/4J5VwoJ A couple things to note here. One, the incognito is much less important to me but a couple things with it draw attention to this bug: 1. The white omnibar 2. There appears to be a major functional secondary bug in this ver of Chrome DEV which is so bad I had to create an actual video grab of it which I converted to a gif for you here (also taken just now in same session): https://imgur.com/hWElLoX As you can see, without ANY extensions allowed to run in incognito (I've triple-checked), not only is the omnibar incorrectly white (suddenly only recently) but the "new tab" page of incognito for some reason FORCES on the bookmark bar, that upon disabling is only honored for subsequent OTHER pages that are not the blank new-tab page. You literally CANNOT even disable the bookmark bar on the "new-tab" page of incognito. Weirder yet, if you watch closely you can see that the forced bookmark bar actually does change visual style slightly (almost as if by theme on/off) when attempting to toggle it. Add all this together that only began a recently without any extensions or the theme changing and it's obvious something is not right. Also, I just ran this same test shown in the video on TWO other systems (also WIN7x64 same Chrome DEV ver) with EXACT same results (all signed into the same chrome acct). Thanks for continuing to look into this hopefully we can get to the bottom of it soon as the white bar is really difficult to deal with all of the sudden.
,
Oct 24
To further confirm, after deleting my theme all together, then I get a dark incognito as you said, still having the pretty serious bookmark bar bug. First screen is plain incognito (no theme), second screen is after simply right-clicking my bookmark-bar and DISABLING IT - note it seems to change it's color to that of the window frame and when you open any site, the bar then disappears. Different bug but I mention since it seems very related to this whole theme issue impacting not only normal mode but incognito as well. No theme incognito looks normal: https://imgur.com/YwhFKCr Then after right-clicking bookmark bar and disabling/unchecking: https://imgur.com/bJhTWoi Then after simply typing google.com into the incognito and hitting enter (note the bookmark bar now disappears): https://imgur.com/j2WQIrY All the above with no theme even installed on version: 71.0.3578.20 (Official Build) dev (64-bit)
,
Oct 27
Why on earth did you label this wontfix before even clearly understanding the issue? Did you read my comments since you jumped to kill it because it's clear you're not understanding the incognito BUG(S) plural you seem to want to use to kill the issue are not even the real issue here. The issue is that I can point you to others that also HAVE BEEN for quite some time themeing the omnibar to make it readable with accessibility and reverse it - let's just totally FORGET incognito for a moment. That has broken. That is a bug. I care less now about incognito it clearly confused everyone when I used it to also show how bad and how many NEW bugs around even having a theme installed there are. And after you look at the non-incognito issue then I'll say your comment makes no sense if I install a theme why it would force incognito to instead now have a WHITE bar NO MATTER THE THEME, just like the broken normal mode omnibar, ALSO NOW FORCED WHITE. Again, the bug is that other than breaking the incognito dark omnibar completely, chrome themes now do NOTHING to the omnibar except force it white, and that cannot possibly be by design. If it is, where is the doc that warns folks that "INSTALLING ANY CHROME THEME WILL ALSO CHANGE YOUR INCOGNITO OMNIBAR TO WHITE - be warned".....do you see my point here? I really think you need to re-think the "wontfix" and please really take a look at these really bad GUI bugs - we users are the ones consuming what you are producing and it's no longer meeting our needs if we cannot read it because you're breaking accessibility.
,
Oct 27
I too am having this problem where my address bar was always dark with my theme and just turned white too how do i get my theme back |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by skare@chromium.org
, Oct 1934.6 KB
34.6 KB View Download