New issue
Advanced search Search tips

Issue 897186 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Oct 30
Cc:
xidac...@chromium.org
sunxd@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 836905



Sign in to add a comment

Objects with "visibility: hidden" should not respect touch-action

Project Member Reported by pdr@chromium.org, Oct 19 
Objects with visibility: hidden do not participate in hit testing (e.g., clicks do not fire events). I do not think we should be respecting touch-action on objects with visibility: hidden either.

Currently we send the compositor touch-action rects for visibility: hidden. This can be seen by loading the testcase and showing touch-action rects [1].

[1] Open the inspector, press escape and enable the rendering tab. Check the "show slow scroll regions" box.
hittestvisibility.html
369 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a743a98854cf20643fd6665146f25511a9955cf

commit 0a743a98854cf20643fd6665146f25511a9955cf
Author: Philip Rogers <pdr@chromium.org>
Date: Sun Oct 28 12:53:38 2018

[PaintTouchActionRects] Do not respect touch-action on visibility:hidden

This patch stops "visibility: hidden" objects from creating hit test
rects because hidden objects do not participate in hit testing. The
non-PaintTouchActionRects result is incorrect and has been temporarily
marked as failing.

Bug:  897186 
Change-Id: If42a619a5b8acb6c205899bc655b4c4e589f6b7b
Reviewed-on: https://chromium-review.googlesource.com/c/1292952
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603375}
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-visibility-hidden-expected.txt
[add] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/WebKit/LayoutTests/fast/events/touch/compositor-touch-hit-rects-visibility-hidden.html
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/block_painter_test.cc
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/box_painter.cc
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/inline_flow_box_painter.cc
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/ng/ng_box_fragment_painter.cc
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/0a743a98854cf20643fd6665146f25511a9955cf/third_party/blink/renderer/core/paint/table_row_painter.cc

Comment 2 by xidac...@chromium.org, Oct 30

Status: Fixed (was: Assigned)
Verified, great work!
►

Sign in to add a comment