Harmonize the firing of accessibility focus events when a window/tab becomes active |
|
Issue descriptionCurrently, some platforms such as Linux ATK require an activate event when a Chrome window receives the focus and a corresponding deactivate event when the window loses focus. Other platforms such as Windows require a focus event when a Chrome window or tab becomes active, but such focus events are currently causing issues with some Windows screen readers when users alt+tab back into a Chrome window. The focus event sometimes moves the screen reader's virtual cursor away from the user's recent location, thereby preventing users from having a positive reading experience. We need to harmonize the way we handle window / tab activation and deactivation across all platforms and remove any unnecessary focus events on Windows.
,
Nov 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e19fa28d291b6fb9d6aa50a1c13f6d6ea7808ed3 commit e19fa28d291b6fb9d6aa50a1c13f6d6ea7808ed3 Author: Nektarios Paisios <nektar@chromium.org> Date: Wed Nov 07 20:30:37 2018 Marks the document object as busy while it is still loading Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 897177 Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02 Reviewed-on: https://chromium-review.googlesource.com/c/1295769 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#606147} [modify] https://crrev.com/e19fa28d291b6fb9d6aa50a1c13f6d6ea7808ed3/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/e19fa28d291b6fb9d6aa50a1c13f6d6ea7808ed3/content/renderer/accessibility/blink_ax_tree_source.cc
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5377a107ddb4ca3860112c3fd111e8073e19c6d1 commit 5377a107ddb4ca3860112c3fd111e8073e19c6d1 Author: Brian Sheedy <bsheedy@chromium.org> Date: Fri Nov 09 00:35:15 2018 Revert "Marks the document object as busy while it is still loading" This reverts commit e19fa28d291b6fb9d6aa50a1c13f6d6ea7808ed3. Reason for revert: Cause of https://crbug.com/903402 Original change's description: > Marks the document object as busy while it is still loading > > Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. > The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Bug: 897177 > Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02 > Reviewed-on: https://chromium-review.googlesource.com/c/1295769 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606147} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897177 Change-Id: Ib13f772ecf7fe300afbb48e16952f65bf0d0728a Reviewed-on: https://chromium-review.googlesource.com/c/1327721 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606658} [modify] https://crrev.com/5377a107ddb4ca3860112c3fd111e8073e19c6d1/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/5377a107ddb4ca3860112c3fd111e8073e19c6d1/content/renderer/accessibility/blink_ax_tree_source.cc
,
Nov 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6b72e6ccca7c64e6127281f1b73beafe72a3b87 commit f6b72e6ccca7c64e6127281f1b73beafe72a3b87 Author: Nektarios Paisios <nektar@chromium.org> Date: Fri Nov 09 23:09:44 2018 Reland: Marks the document object as busy while it is still loading Changes in the reland compared to the original patch: Switched to using GetRoot instead of Root() which might prevent the use of an uninitialized root object. Original description: Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 897177, 903402 Change-Id: I681883999918ffdd32fc11d2f691b659c7e91149 Reviewed-on: https://chromium-review.googlesource.com/c/1327745 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#607017} [modify] https://crrev.com/f6b72e6ccca7c64e6127281f1b73beafe72a3b87/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/f6b72e6ccca7c64e6127281f1b73beafe72a3b87/content/renderer/accessibility/blink_ax_tree_source.cc
,
Nov 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d75cb3836e9681afc799e7c7ae7101e9f1ad267f commit d75cb3836e9681afc799e7c7ae7101e9f1ad267f Author: Brian Sheedy <bsheedy@chromium.org> Date: Mon Nov 12 20:58:22 2018 Revert "Reland: Marks the document object as busy while it is still loading" This reverts commit f6b72e6ccca7c64e6127281f1b73beafe72a3b87. Reason for revert: Still causing https://crbug.com/903402 Original change's description: > Reland: Marks the document object as busy while it is still loading > > Changes in the reland compared to the original patch: > Switched to using GetRoot instead of Root() which might prevent the use of an uninitialized root object. > > Original description: > Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it. > The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > Bug: 897177, 903402 > Change-Id: I681883999918ffdd32fc11d2f691b659c7e91149 > Reviewed-on: https://chromium-review.googlesource.com/c/1327745 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607017} TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897177, 903402 Change-Id: I18b4bae20db26dc26934abb08e97df0b8a151465 Reviewed-on: https://chromium-review.googlesource.com/c/1331145 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#607319} [modify] https://crrev.com/d75cb3836e9681afc799e7c7ae7101e9f1ad267f/content/browser/accessibility/browser_accessibility_manager.cc [modify] https://crrev.com/d75cb3836e9681afc799e7c7ae7101e9f1ad267f/content/renderer/accessibility/blink_ax_tree_source.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Oct 22