New issue
Advanced search Search tips

Issue 897173 link

Starred by 1 user
Status: Duplicate
Merged: issue 469947
Owner: ----
Closed: Jan 18
Cc:
wjmaclean@chromium.org
mcnee@chromium.org
lanwei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

SyntheticTouchscreenPinchGesture final scales are imprecise.

Project Member Reported by wjmaclean@chromium.org, Oct 19 
Observed when running

TouchSelectionControllerClientAndroidSiteIsolationTest.SelectionThenPinchInOOPIF

The final value of the page scale can be off the desired value by quite a bit. This is problematic in tests if we want to use reaching the target page scale factor to synchronize test behaviour.

(Related: the member |scale_factor| in SyntheticPinchGestureParams should really be page_scale_factor_delta, since the final page_scale_factor after the gesture is equal to the original page scale factor multiplied by SyntheticPinchGestureParams::scale_factor.)
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f318fc438bc6ac46d5b568663ae5efd222e03ee3

commit f318fc438bc6ac46d5b568663ae5efd222e03ee3
Author: Donn Denman <donnd@chromium.org>
Date: Sat Nov 17 01:19:45 2018

Disable flaky test SelectionThenPinchInOOPIF.

This test is flaking a lot on Android now.  Disabling.

TBR=wjmaclean@chromium.org

BUG=906204,  897173 

Change-Id: I4226c043de09fd5cb6fd83343bbfac5b69a802d4
Reviewed-on: https://chromium-review.googlesource.com/c/1341140
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609060}
[modify] https://crrev.com/f318fc438bc6ac46d5b568663ae5efd222e03ee3/content/browser/site_per_process_browsertest.cc

Comment 2 by wjmaclean@chromium.org, Jan 18 (4 days ago)

Mergedinto: 469947
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment