Check IsStorageProtected when clearing SessionOnly storage |
||
Issue descriptionThe implementations for AppCache, DOMStorage, WebSQL and Indexed DB check SpecialStoragePolicy::IsStorageProtected and exempt such origins when purging origins with SpecialStoragePolicy::IsStorageSessionOnly. e.g. see: https://cs.chromium.org/chromium/src/content/browser/dom_storage/dom_storage_context_impl.cc?sq=package:chromium&g=0&l=317 https://cs.chromium.org/chromium/src/storage/browser/database/database_tracker.cc?sq=package:chromium&g=0&l=854 Service Worker and Cache Storage don't have such a clause. e.g. see: https://cs.chromium.org/chromium/src/content/browser/service_worker/service_worker_storage.cc?dr=CSs&g=0&l=1770 The same logic should be applied consistently.
,
Oct 22
,
Oct 22
Can I handle this issue if no one working on this issue?
,
Oct 22
Sure, take it :)
,
Oct 22
note that the CacheStorage change I made which would need precede the change here hasn't landed yet (well, it did but was reverted): https://chromium-review.googlesource.com/c/chromium/src/+/1288890
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6055a0bc6ddef7ac82be4dea88bb092a34c0f1df commit 6055a0bc6ddef7ac82be4dea88bb092a34c0f1df Author: Jaeyong Bae <jdragon.bae@gmail.com> Date: Thu Oct 25 16:17:44 2018 ServiceWorker: Check IsStorageProtected when clearing SessionOnly storage The implementations for Service Worker check SpecialStoragePolicy::IsStorageProtected and exempt such origins when purging origins with SpecialStoragePolicy::IsStorageSessionOnly. The logic was applied in AppCache, DOMStorage, WebSQL and Indexed DB. Bug: 897171 Change-Id: I8150b762803afb262cde861641e4bb953515a105 Reviewed-on: https://chromium-review.googlesource.com/c/1293929 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#602734} [modify] https://crrev.com/6055a0bc6ddef7ac82be4dea88bb092a34c0f1df/content/browser/service_worker/service_worker_storage.cc |
||
►
Sign in to add a comment |
||
Comment 1 by jsb...@chromium.org
, Oct 19