New issue
Advanced search Search tips

Issue 897167 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 887659



Sign in to add a comment

[animation worklet] Output of WorkletAnimation is not trimmed on main thread

Project Member Reported by yigu@chromium.org, Oct 19

Issue description

If the iteration of an effect is not defined, local time should be trimmed by the duration. Unlike cc::KeyframeEffect, main thread currently doesn't handle cases like this.
 
Status: WontFix (was: Assigned)
The statement is no longer valid.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/419d3dc49ac7f9b004dda03493655513b8a5782f

commit 419d3dc49ac7f9b004dda03493655513b8a5782f
Author: Yi Gu <yigu@chromium.org>
Date: Fri Nov 16 17:01:10 2018

[animation worklet] Add tests for fill mode behavior

Previously upon setting the local time beyond its duration we assumed
the behavior should be the same as we set it to the end point. However,
it's only true if the effect has fill mode: fowards specified. Otherwise
the animation should be deactivated. The expected behavior for the test
is updated.

Added a new test to cover the animation behaviors with fill modes.

Bug:  897167 
Change-Id: Iecbf9e86e137ff2b98cdc0f2602222c49470e21e
Reviewed-on: https://chromium-review.googlesource.com/c/1308084
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608813}
[modify] https://crrev.com/419d3dc49ac7f9b004dda03493655513b8a5782f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/419d3dc49ac7f9b004dda03493655513b8a5782f/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-local-time-after-duration-expected.html
[modify] https://crrev.com/419d3dc49ac7f9b004dda03493655513b8a5782f/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-local-time-after-duration.html
[add] https://crrev.com/419d3dc49ac7f9b004dda03493655513b8a5782f/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-with-fill-mode.html

Sign in to add a comment