New issue
Advanced search Search tips

Issue 897163 link

Starred by 3 users
Status: Fixed
Owner:
ma...@igalia.com
Closed: Oct 25
Cc:
blundell@chromium.org
toniki...@chromium.org
sdefresne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 887449


Sign in to add a comment

Migrate UserPolicySigninService to the IdentityManager

Project Member Reported by ma...@igalia.com, Oct 19 
There are several places in UserPolicySigninService besides the bits related to O2TS::Observer and SigninManagerBase::Observer (which will be migrated as part of  crbug.com/887449 ) where the O2TS class is being used, that could be replaced by the IdentityManager, ideally after bugs  887449  and  887449  have been fixed.

Implements:
  - O2TS::RefreshTokenIsAvailable()
  - O2TS::StartRequest()
  - O2TS::Consumer (OnGetTokenSuccess() and OnGetTokenFailure())

Note that in order to migrate this some additional changes in the clients will be required (e.g. CloudPolicyClientRegistrationHelper).

I have a WIP CL based on CL 1290931 that I will be attaching soon after I get that other one passing in the bots.

=> self-assigning for now

Comment 1 by ma...@igalia.com, Oct 19

Cc: sdefresne@chromium.org blundell@chromium.org

Comment 2 by ma...@igalia.com, Oct 23

Status: Started (was: Assigned)

Comment 3 by toniki...@chromium.org, Oct 23

Cc: toniki...@chromium.org
 Issue 890782  has been merged into this issue.

Comment 4 by toniki...@chromium.org, Oct 23 

 Issue 890781  has been merged into this issue.

Comment 5 by toniki...@chromium.org, Oct 23 

 Issue 890783  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa4fdf56608b32896cd7dd733ad623e7474a9f1c

commit fa4fdf56608b32896cd7dd733ad623e7474a9f1c
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Thu Oct 25 16:15:22 2018

Migrate UserPolicySigninService to the IdentityManager

Remove all references to ProfileOAuth2TokenService from the
user_policy_signin_service_* files, in favor of IdentityManager,
which implied changing the signature (and update all its clients)
of CloudPolicyClientRegistrationHelper::StartRegistration().

Bug:  897163 
Change-Id: Ie78135727a1266580f4bbdfada9fc0235022d21d
Reviewed-on: https://chromium-review.googlesource.com/c/1291314
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602733}
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/policy/cloud/user_policy_signin_service.cc
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/policy/cloud/user_policy_signin_service.h
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/policy/cloud/user_policy_signin_service_factory.cc
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/policy/cloud/user_policy_signin_service_mobile.cc
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/policy/cloud/user_policy_signin_service_mobile.h
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/chrome/browser/ui/webui/signin/dice_turn_sync_on_helper_unittest.cc
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/components/policy/core/common/BUILD.gn
[add] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/components/policy/core/common/cloud/DEPS
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc
[modify] https://crrev.com/fa4fdf56608b32896cd7dd733ad623e7474a9f1c/components/policy/core/common/cloud/cloud_policy_client_registration_helper.h

Comment 7 by ma...@igalia.com, Oct 25

Status: Fixed (was: Started)
►

Sign in to add a comment