Issue metadata
Sign in to add a comment
|
Tabstrip focus traversal order does not match visual order
Reported by
vineetha...@etouch.net,
Oct 19
|
||||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3585.0 (Official Build)Revision 2eea43d10d3448c382da58fa116d4391f0d9db6d-refs/branch-heads/3585@{#1}(32/64 bit) OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1. Launch Chrome, open 3 to 4 tabs. 2. Change the order of tabs by dragging/dropping them. 3. Press F6 such that blue focus ring is seen on tabs in tab strip. 4. Now press right arrow key and observe. Actual : Blue focus ring traverses over the tabs in the sequence in which they were created on pressing right arrow key. Expected : Blue focus ring should traverse in serial order(i.e. over the next immediate tab to the right) on pressing right arrow key irrespective of the sequence in which they were created. This is a non-regression issue, seen from M72 (build #72.0.3582.0). Kindly refer attached screen cast. Note: 1)Pardon me if this is an intended change. 2)Issue is specific to Windows OS. Thank you
,
Oct 19
I thought sure there was a bug on this but I can't find it. I believe tab traversal order always follows the child order, which in turn is based on when tabs were created. It should always follow the visual order instead (or we should reorder children on dragging, which would achieve the same thing). That said, I actually can't reproduce because I can't seem to get keyboard focus into the tabstrip. F6 for me on Windows just toggles between toolbar and web content.
,
Nov 9
I can reproduce on dev 72.0.3602.2. I added tab strip keyboard focus so I'll work on fixing this.
,
Nov 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49b47da02e0975e274eb7e6328cc16975bcb31e4 commit 49b47da02e0975e274eb7e6328cc16975bcb31e4 Author: Collin Baker <collinbaker@chromium.org> Date: Wed Nov 14 19:28:09 2018 Make tab view order match tab strip model order Bug: 897086 Change-Id: Idfd8e9a68c663ba3e560a6f2443b2a468cdd3c65 Reviewed-on: https://chromium-review.googlesource.com/c/1331617 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#608076} [modify] https://crrev.com/49b47da02e0975e274eb7e6328cc16975bcb31e4/chrome/browser/ui/views/tabs/tab_strip.cc [modify] https://crrev.com/49b47da02e0975e274eb7e6328cc16975bcb31e4/chrome/browser/ui/views/tabs/tab_strip_unittest.cc
,
Nov 16
This should be fixed now |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Oct 19