Issue metadata
Sign in to add a comment
|
6.4% regression in blink_perf.owp_storage at 600677:600708 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 19
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/128df532e40000
,
Oct 19
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/128df532e40000 [DOMStorage] Enable onion soup codepath by dmurph@chromium.org https://chromium.googlesource.com/chromium/src/+/80ce30280a48850aad465138b84fe209474733e8 Registry::RegisterBlob: 379.4 → 393.8 (+14.46) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/blink-perf-benchmarks
,
Oct 30
I'm not sure how this would increase the blob registration time - other than maybe we're competing for that event queue? Does blob registration run on the IPCTaskRunner? +mek
,
Nov 6
What this is measuring is how long this one particular sync mojo call takes (i.e. how busy the browser process is at the time of trying to register the blob). Not sure how this would have an impact; looking at the actual changes is somewhat interesting though, as it seems that the time this takes has become a bit more bi-modal. While before there was only one peak in the distribution of times, now for at least -ipc, -tiny and -shm there is a second (lower!) peak, so a lot of registrations actually complete faster. The "main" peak just is apparently slightly slower enough to overall come out in the negative. But agree that there is nothing here to worry about. Difference is tiny anyway. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 19