New issue
Advanced search Search tips

Issue 897058 link

Starred by 1 user
Status: Fixed
Owner:
mukai@chromium.org
Closed: Oct 23
Cc:
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: CommandsApiTest.DontOverwriteSystemShortcuts

Blocked on:
issue 891489


Sign in to add a comment

CommandsApiTest.DontOverwriteSystemShortcuts is flaky

Project Member Reported by Findit, Oct 19 

Flaky test: CommandsApiTest.DontOverwriteSystemShortcuts
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14895
Test output log: https://chromium-swarm.appspot.com/task?id=40a411655781ad10
Culprit (70.0% confidence): r600948
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0ODk1L3NpbmdsZV9wcm9jZXNzX21hc2hfaW50ZXJhY3RpdmVfdWlfdGVzdHMvUTI5dGJXRnVaSE5CY0dsVVpYTjBMa1J2Ym5SUGRtVnlkM0pwZEdWVGVYTjBaVzFUYUc5eWRHTjFkSE09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20CommandsApiTest.DontOverwriteSystemShortcuts&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyyQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKSAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzE0ODk1L3NpbmdsZV9wcm9jZXNzX21hc2hfaW50ZXJhY3RpdmVfdWlfdGVzdHMvUTI5dGJXRnVaSE5CY0dsVVpYTjBMa1J2Ym5SUGRtVnlkM0pwZEdWVGVYTjBaVzFUYUc5eWRHTjFkSE09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).

Comment 1 by dullweber@chromium.org, Oct 19

Owner: sky@chromium.org
Status: Assigned (was: Untriaged)
Findit thinks that https://chromium-review.googlesource.com/c/chromium/src/+/1262405 introduced flakiness. 

This CL is already a revert that is supposed to fix issues with single_process_mash_interactive_ui_tests, I'm not sure if reverting it again would improve the overall situation. 
Please take a look

Comment 2 by sky@chromium.org, Oct 19 

https://chromium-review.googlesource.com/c/chromium/src/+/1262405  was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1289993 . Jun recently added this suite to the bots. I think this particular has likely always been flaky (on single-process mash). I'm going to disable.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f8bf79c502dbc51c4eb75f639a217cbc4a37c3a

commit 8f8bf79c502dbc51c4eb75f639a217cbc4a37c3a
Author: Scott Violet <sky@chromium.org>
Date: Fri Oct 19 16:49:47 2018

Disables CommandsApiTest.DontOverwriteSystemShortcuts

on single-process mash (interactive ui tests). It's flaky.

BUG= 897058 
TEST=test only change
TBR=mukai@chromium.org

Change-Id: I1eaea1ca641f01d4d8e2fb749e497d11c7ec6b1e
Reviewed-on: https://chromium-review.googlesource.com/c/1291690
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601186}
[modify] https://crrev.com/8f8bf79c502dbc51c4eb75f639a217cbc4a37c3a/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8161839d27131b49dbef81e2ad39e4ce5af720e

commit c8161839d27131b49dbef81e2ad39e4ce5af720e
Author: Scott Violet <sky@chromium.org>
Date: Fri Oct 19 17:21:22 2018

Disables NavigationControllerBrowserTest.EnsureFrameNavigationEntriesClearedOnMismatch

It's flaky on ChromeOS as well.

BUG= 897058 
TEST=test only change
TBR=lukasza@chromium.org

Change-Id: I11cc721b303a738d1c1b799170887b9b5aa67db6
Reviewed-on: https://chromium-review.googlesource.com/c/1291412
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601201}
[modify] https://crrev.com/c8161839d27131b49dbef81e2ad39e4ce5af720e/content/browser/frame_host/navigation_controller_impl_browsertest.cc

Comment 5 by mukai@chromium.org, Oct 19

Cc: sky@chromium.org
Owner: mukai@chromium.org
Status: Started (was: Assigned)
I will look into this. Before adding the suite to the main waterfall, it was flaky on the FYI bot, but I thought I fixed the flakiness. Maybe that fix wasn't enough.

Comment 6 by mukai@chromium.org, Oct 19

Labels: Proj-Mash-SingleProcess

Comment 7 by mukai@chromium.org, Oct 19 

Ah, what I fixed was a different test (CommandsApiTest.PageActionOverrideChromeShortcut) so that's unaffected. Looking what was wrong in this DontOverwriteSystemShortcuts case.

Comment 8 by yigu@chromium.org, Oct 22

Labels: -Sheriff-Chromium

Comment 9 by mukai@chromium.org, Oct 22

Blockedon: 891489
Labels: -Pri-1 Pri-2
Status: Assigned (was: Started)
It is actually related to  issue 891489 . Will wait for it getting fixed, and then I'll revisit this.

Comment 10 by mukai@chromium.org, Oct 23

Status: Fixed (was: Assigned)
Fixed fully by sky@
►

Sign in to add a comment