New issue
Advanced search Search tips

Issue 897052 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

pinpoint_cli: failed test runs cause other successful runs to be skipped

Project Member Reported by perezju@chromium.org, Oct 19

Issue description

Tests that completed with failures would have no 'isolate', this currently triggers a bug in the old code which causes remaining attempts for the same change to be silently skipped.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e180c3c4cce455a218fd7b1ffd4efd8b7618ee4b

commit e180c3c4cce455a218fd7b1ffd4efd8b7618ee4b
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Oct 22 09:05:49 2018

[pinpoint_cli] Fix bug when iterating over output isolates

Tests that completed with failures would have no 'isolate', this would
trigger a bug in the old code causing remaining attempts for the same
change to be silently skipped.

Fix this bug so only the failed test is skipped.

Bug:  chromium:897052 
Change-Id: I1def9c71f535c2601e8844ca1841b2e83433666c
Reviewed-on: https://chromium-review.googlesource.com/c/1290932
Reviewed-by: Dave Tu <dtu@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/e180c3c4cce455a218fd7b1ffd4efd8b7618ee4b/experimental/soundwave/pinpoint_cli/job_results.py
[modify] https://crrev.com/e180c3c4cce455a218fd7b1ffd4efd8b7618ee4b/experimental/soundwave/pinpoint_cli/job_results_test.py

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fea12d58a43018330c3ae256917b0edfdebc256e

commit fea12d58a43018330c3ae256917b0edfdebc256e
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Oct 22 10:02:49 2018

Roll src/third_party/catapult b026043a43f9..b20529ac11a6 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/b026043a43f9..b20529ac11a6


git log b026043a43f9..b20529ac11a6 --date=short --no-merges --format='%ad %ae %s'
2018-10-22 perezju@chromium.org [soundwave] Fix encoding when building RequestError message
2018-10-22 perezju@chromium.org [pinpoint_cli] Fix bug when iterating over output isolates


Created with:
  gclient setdep -r src/third_party/catapult@b20529ac11a6

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:897178 , chromium:897052 
TBR=sullivan@chromium.org

Change-Id: I5ca0605b6d78dc87a31ef59c2d0257bf9bffe390
Reviewed-on: https://chromium-review.googlesource.com/c/1293242
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601512}
[modify] https://crrev.com/fea12d58a43018330c3ae256917b0edfdebc256e/DEPS

Sign in to add a comment