Issue metadata
Sign in to add a comment
|
Regression : Chrome becomes unresponsive after right clicking 'twice' on extension icon in 'Wrench' menu.
Reported by
avsha...@etouch.net,
Oct 19
|
||||||||||||||||||||||
Issue descriptionChrome Version : 72.0.3585.0 (Official Build) 2eea43d10d3448c382da58fa116d4391f0d9db6d-refs/branch-heads/3585@{#1} 64 bit OS : Mac(10.13.1, 10.13.6, 10.14.1) Test URL : https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm?utm_source=chrome-ntp-icon What steps will reproduce the problem? 1. Launch chrome, open 'Web Store' and add any extension (For Example, Add 'PDF Viewer' from above test URL). 2. After adding an extension, drag extension icon from toolbar and drop it in 'Wrench' menu. 3. Open 'Wrench' menu and right click twice on extension icon. (Kindly review an attached screen cast) 4. Observe. Actual Result : Chrome becomes unresponsive after right clicking 'twice' on extension icon in 'Wrench' menu. Expected Result : After step 3, right click context menu should appear and Chrome should not become unresponsive. This is a regression issue broken in M-71 and below is the bisect information: Good Build : 71.0.3563.0 (Revision :) Bad Build : 71.0.3564.0 (Revision :) Chromium bisect URL: https://chromium.googlesource.com/chromium/src/+log/b8d2f6ccc20a278c136defd39b783a7683a5a285..5adf37cfebecab32512d95bcaa67a591130b6774 Suspecting : r594738 ? Elly Fong@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. This issue can be reproduced with any extension available in 'web store'. 2. Able to reproduce issue in Dev build #71.0.3578.10 3. Unable to provide bisect using 'per-revision' script as it shows traceback error, hence provided suspect through 'Chromium bisect'. 4. This is Mac OS specific issue and the same is not reproducible in Linux(14.04) & Windows(7,8,10) OS. Thank you..!
,
Oct 19
,
Oct 22
Related to issue 893085 probably.
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edbe0951624f7920397dd7fd0d77cc76781842c4 commit edbe0951624f7920397dd7fd0d77cc76781842c4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Oct 22 19:57:07 2018 macviews: fix menu closure when click hits a parent menu This change: 1) Has MenuController reset the closure animation once ::Cancel runs, since it is legal for the MenuController to remain alive after ::Cancel (in fact this is how submenus work); 2) Has the menu closure animation in ::RepostEventAndCancel() target the active submenu instead of the root submenu when closing the outermost menu. into invisibility but in fact only the outermost one is really dismissed, leaving the other menu windows with invisible mouse capture. Bug: 893085 , 897045 Change-Id: I839710cc525856b14bd3995707ab253cb3258f5f Reviewed-on: https://chromium-review.googlesource.com/c/1293792 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601696} [modify] https://crrev.com/edbe0951624f7920397dd7fd0d77cc76781842c4/ui/views/controls/menu/menu_controller.cc
,
Oct 22
,
Oct 22
[Auto-generated comment by a script] We noticed that this issue is targeted for M-71; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-71 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 22
Pls request a merge to M71 once change listed at #4 is baked/verified in canary.
,
Oct 23
--------- Update : --------- Verified above issue in latest Canary build #72.0.3589.0 on Mac(10.13.1, 10.13.6, 10.14.1) OS and the issue is fixed. Right clicking twice on Extension icon does not make Chrome unresponsive and it is working as intended, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..!
,
Oct 23
The NextAction date has arrived: 2018-10-23
,
Oct 23
Requesting merge to M71.
,
Oct 23
Removing "Merge-TBD" as M71 merge is requested at #10.
,
Oct 24
Your change meets the bar and is auto-approved for M71. Please go ahead and merge the CL to branch 3578 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 24
Pls merge you change to M71 branch 3578 ASAP so we can pick it up for next week beta release. Thank you.
,
Oct 26
ellyjones@ is OOO. +sky@ (CL reviewer), pls merge the change to M71 branch 3578. Thank you.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1a51b1f62b3b44096a52b6e6d40a9c0a4d25631 commit c1a51b1f62b3b44096a52b6e6d40a9c0a4d25631 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Oct 26 17:41:54 2018 [MERGE] macviews: fix menu closure when click hits a parent menu This change: 1) Has MenuController reset the closure animation once ::Cancel runs, since it is legal for the MenuController to remain alive after ::Cancel (in fact this is how submenus work); 2) Has the menu closure animation in ::RepostEventAndCancel() target the active submenu instead of the root submenu when closing the outermost menu. into invisibility but in fact only the outermost one is really dismissed, leaving the other menu windows with invisible mouse capture. Bug: 893085 , 897045 Change-Id: I839710cc525856b14bd3995707ab253cb3258f5f Reviewed-on: https://chromium-review.googlesource.com/c/1293792 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601696}(cherry picked from commit edbe0951624f7920397dd7fd0d77cc76781842c4) Reviewed-on: https://chromium-review.googlesource.com/c/1302107 Cr-Commit-Position: refs/branch-heads/3578@{#347} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/c1a51b1f62b3b44096a52b6e6d40a9c0a4d25631/ui/views/controls/menu/menu_controller.cc
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1a51b1f62b3b44096a52b6e6d40a9c0a4d25631 Commit: c1a51b1f62b3b44096a52b6e6d40a9c0a4d25631 Author: ellyjones@chromium.org Commiter: sky@chromium.org Date: 2018-10-26 17:41:54 +0000 UTC [MERGE] macviews: fix menu closure when click hits a parent menu This change: 1) Has MenuController reset the closure animation once ::Cancel runs, since it is legal for the MenuController to remain alive after ::Cancel (in fact this is how submenus work); 2) Has the menu closure animation in ::RepostEventAndCancel() target the active submenu instead of the root submenu when closing the outermost menu. into invisibility but in fact only the outermost one is really dismissed, leaving the other menu windows with invisible mouse capture. Bug: 893085 , 897045 Change-Id: I839710cc525856b14bd3995707ab253cb3258f5f Reviewed-on: https://chromium-review.googlesource.com/c/1293792 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#601696}(cherry picked from commit edbe0951624f7920397dd7fd0d77cc76781842c4) Reviewed-on: https://chromium-review.googlesource.com/c/1302107 Cr-Commit-Position: refs/branch-heads/3578@{#347} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 31
--------- Update : --------- Verified above issue in latest Beta build #71.0.3578.30 on Mac(10.13.1, 10.13.6, 10.14.1) OS and the issue is fixed. Right clicking twice on extension icon doesn't make Chrome unresponsive and it is working as intended, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference. Thank you..! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Oct 19Labels: ReleaseBlock-Beta