New issue
Advanced search Search tips

Issue 897019 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

blinkpy.web_tests.run_webkit_tests_unittest.RebaselineTest.test_new_platform_baseline_without_fallback and 4 other(s) in webkit_python_tests failing on chromium.linux/linux-xenial-rel

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Oct 19

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dullweber@google.com

blinkpy.web_tests.run_webkit_tests_unittest.RebaselineTest.test_new_platform_baseline_without_fallback and 4 other(s) in webkit_python_tests failing on chromium.linux/linux-xenial-rel

Builders failed on: 
- linux-xenial-rel: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel


 
Cc: wangxianzhu@chromium.org
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/4275

Unexpected Failures:
* blinkpy.web_tests.run_webkit_tests_unittest.RebaselineTest.test_new_platform_baseline_without_fallback
* blinkpy.web_tests.run_webkit_tests_unittest.RebaselineTest.test_reset_results_missing_results
* blinkpy.web_tests.run_webkit_tests_unittest.RunTest.test_no_tests_found_with_ok_flag_shards
* blinkpy.web_tests.run_webkit_tests_unittest.RunTest.test_retrying_alias_flag
* blinkpy.web_tests.run_webkit_tests_unittest.RunTest.test_retrying_default_value


expecting CL: https://chromium.googlesource.com/chromium/src/+/dcf5246f166884166122a55f11b6fae0297bf9f6

will revert to see if that fixes the issue
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee22baed82b3806d7a06a2b1d552063b61744df5

commit ee22baed82b3806d7a06a2b1d552063b61744df5
Author: Christian Dullweber <dullweber@chromium.org>
Date: Fri Oct 19 07:57:31 2018

Revert "[run_web_tests] Initialize printer earlier"

This reverts commit dcf5246f166884166122a55f11b6fae0297bf9f6.

Reason for revert: It looks like this broke web_tests on linux-xenial-rel 

Original change's description:
> [run_web_tests] Initialize printer earlier
> 
> This allows logging before creating the port.
> 
> Bug:  896799 
> Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6
> Reviewed-on: https://chromium-review.googlesource.com/c/1289305
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Cr-Commit-Position: refs/heads/master@{#601049}

TBR=wangxianzhu@chromium.org,dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org

Change-Id: I71ae432b2db53611d6cd44d788d8f450e714ba78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  896799 ,  897019 
Reviewed-on: https://chromium-review.googlesource.com/c/1290151
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601076}
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner.py
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/controllers/layout_test_runner_unittest.py
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/views/printing.py
[modify] https://crrev.com/ee22baed82b3806d7a06a2b1d552063b61744df5/third_party/blink/tools/blinkpy/web_tests/views/printing_unittest.py

Cc: -wangxianzhu@chromium.org
Labels: -Sheriff-Chromium
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
The last test run was successful
Cc: nedngu...@google.com
Is it intentional that the bot was green while webkit_python_tests failed?
I don't think so. There is another bug (https://bugs.chromium.org/p/chromium/issues/detail?id=896175) about this weird behavior
Status: Fixed (was: Assigned)

Sign in to add a comment