Issue metadata
Sign in to add a comment
|
LogDog frontend does not escape characters like '<' |
||||||||||||||||||||||
Issue descriptionExample: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932258721358298528/+/steps/compile__with_patch_/0/stdout Error messages containing '<' are rendered incorrectly, like: > .../hash_table.h(604,14): error: object of type 'WTF::KeyValuePair > >' cannot be assigned... The HTML source actually contains the right message. It just doesn't HTML-escape those symbols: > .../hash_table.h(604,14): error: object of type 'WTF::KeyValuePair<blink::Thread::TaskObserver *, std::unique_ptr<blink::Thread::TaskObserverAdapter, std::default_delete<blink::Thread::TaskObserverAdapter> > >' cannot be assigned... This also reproduces in "raw_io" view, as in: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932258721358298528/+/steps/compile__with_patch_/0/logs/raw_io.output_failure_summary_/0 This bug makes complex C++ errors hard to examine!
,
Oct 19
In the meantime, you can click "switch to full mode" and it should render okay.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/174cfa5749dbaffef5ce11aa635d7a43d0400636 commit 174cfa5749dbaffef5ce11aa635d7a43d0400636 Author: Ryan Tseng <hinoka@google.com> Date: Fri Oct 19 17:50:54 2018 [logdog] Escape lines in lite mode This changes the behavior to make lite mode and raw mode behave slightly differently. Lite mode: Escape lines then emit them, with \n Raw mode: Emit lines, and emit the original deliminator. Bug: 897017 Change-Id: I4c6a81d830ddeb5d3e150b2b58ee9a2395eacf46 Reviewed-on: https://chromium-review.googlesource.com/c/1291969 Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> [modify] https://crrev.com/174cfa5749dbaffef5ce11aa635d7a43d0400636/logdog/appengine/coordinator/flex/logs/http.go
,
Oct 19
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by hinoka@chromium.org
, Oct 19Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)