Flaky test: OneTaskSchedulerImplTestParams/TaskSchedulerImplTest.GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated/27 Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.memory/Linux%20CFI/10808 Test output log: https://chromium-swarm.appspot.com/task?id=40a38e881e30c610 Culprit (100.0% confidence): r600401 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy9gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK_AWNocm9taXVtLm1lbW9yeS9MaW51eCBDRkkvMTA4MDgvYmFzZV91bml0dGVzdHMvVDI1bFZHRnphMU5qYUdWa2RXeGxja2x0Y0d4VVpYTjBVR0Z5WVcxekwxUmhjMnRUWTJobFpIVnNaWEpKYlhCc1ZHVnpkQzVIWlhSTllYaERiMjVqZFhKeVpXNTBUbTl1UW14dlkydGxaRlJoYzJ0elYybDBhRlJ5WVdsMGMwUmxjSEpsWTJGMFpXUXZNamM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20OneTaskSchedulerImplTestParams/TaskSchedulerImplTest.GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated/27&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy9gELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK_AWNocm9taXVtLm1lbW9yeS9MaW51eCBDRkkvMTA4MDgvYmFzZV91bml0dGVzdHMvVDI1bFZHRnphMU5qYUdWa2RXeGxja2x0Y0d4VVpYTjBVR0Z5WVcxekwxUmhjMnRUWTJobFpIVnNaWEpKYlhCc1ZHVnpkQzVIWlhSTllYaERiMjVqZFhKeVpXNTBUbTl1UW14dlkydGxaRlJoYzJ0elYybDBhRlJ5WVdsMGMwUmxjSEpsWTJGMFpXUXZNamM9DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
reverting the cl: https://chromium-review.googlesource.com/c/chromium/src/+/1290152
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f35cfff25c14541157baac2fe8014b3bf825e766 commit f35cfff25c14541157baac2fe8014b3bf825e766 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Oct 19 10:49:09 2018 Revert "[Task Scheduler]: Merge blocking and non-blocking pools." This reverts commit 7a77c4e0ebcf65032537f1fb21f2e7cad609ed97. Reason for revert: Findit identified that this introduced flakiness and it looks reasonable. Please take a look Original change's description: > [Task Scheduler]: Merge blocking and non-blocking pools. > > This CL creates a feature experiment that removes blocking worker pools > from the task scheduler. Tasks with MayBlock trait are instead posted to > the usual foreground/background pool, giving us better control over scheduling. > > Note: ScopedBlockingCall is used to add extra workers to the pool when a task is > blocking. In this CL, we take advantage of this behavior to make sure enough > workers are running on the CPU. > > Bug: 874080 > Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69 > Reviewed-on: https://chromium-review.googlesource.com/c/1249836 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600401} TBR=gab@chromium.org,fdoray@chromium.org,rkaplow@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874080, 897014 Change-Id: I5d125aba916dfb0dfce791b4d0a5b1ca5e6035d9 Reviewed-on: https://chromium-review.googlesource.com/c/1290152 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601106} [modify] https://crrev.com/f35cfff25c14541157baac2fe8014b3bf825e766/base/task/task_scheduler/task_scheduler_impl.cc [modify] https://crrev.com/f35cfff25c14541157baac2fe8014b3bf825e766/base/task/task_scheduler/task_scheduler_impl.h [modify] https://crrev.com/f35cfff25c14541157baac2fe8014b3bf825e766/base/task/task_scheduler/task_scheduler_impl_unittest.cc [modify] https://crrev.com/f35cfff25c14541157baac2fe8014b3bf825e766/testing/variations/fieldtrial_testing_config.json
Comment 1 by dullweber@chromium.org
, Oct 19