New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 897006 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [NTP] Unwanted movement of thumbnails is seen after hovering mouse on it.

Reported by db...@etouch.net, Oct 19

Issue description

Chrome Version: 72.0.3585.0 Revision 2eea43d10d3448c382da58fa116d4391f0d9db6d-refs/branch-heads/3585@{#1}(32/64 bit)
OS: Windows(7,8,8.1,10)

Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, open NTP and hover mouse on thumbnails and observe.

Actual: Unwanted movement of thumbnails is seen after hovering mouse on it.

Expected: No such a movement should seen.

This is a regression issue, broken in 'M72', will soon update the other info:

Good Build:72.0.3584.0
Bad Build: 72.0.3585.0


 
Actual_Hover.mp4
330 KB View Download
Expected_Hover.mp4
113 KB View Download
Labels: hasbisect OS-Linux OS-Mac
Owner: kristip...@chromium.org
Status: Assigned (was: Unconfirmed)
ChangeLog info:

https://chromium.googlesource.com/chromium/src/+log/72.0.3584.0..72.0.3585.0?pretty=fuller&n=10000

Suspect: https://chromium.googlesource.com/chromium/src/+/adf056599a25e3d59d1272de431aae24b549f927

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Tried performing 'per revision' bisect on multiple Windows and Mac machines but unable to perform the same since getting "RuntimeError: We don't have enough builds to bisect." error.
2. Unable to perform Chromium bisect as 'File is not a zip file' Error is seen.
3. Hence providing suspect manually.
4. Issue is also seen on Mac(10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS)
Cc: wangxianzhu@chromium.org
+wangxianzhu

Suspecting that the fix introduced in  bug 627683  is causing this issue. The jitter occurs when the tile menu opacity is modified on hover. Removing the 500ms transition delay from the tile menu stops the jitter.
Setting any size border on the "mv-single" iframe fixes the jitter. Quick fix is to set a transparent 1px border, but I'm unsure why "border: none"/"border: 0" would cause jittering now.
Feel free to assign to me for investigation of the root cause. Any reduced test case would be appreciated.
Owner: wangxianzhu@chromium.org
Attached a slimmed down test case. After playing around with it, there's some weirdness around "text-align: -webkit-center", odd value widths and iframes that result in a jitter.
test.html
1.4 KB View Download
Labels: zine-triaged
Cc: kristip...@chromium.org ramyan@chromium.org
t
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c531d2d75306cee6da5c07120289352cc065f700

commit c531d2d75306cee6da5c07120289352cc065f700
Author: Kristi Park <kristipark@chromium.org>
Date: Wed Oct 24 00:45:45 2018

[NTP] Fix 1px jitter in custom link tiles

Temporary fix for the 1px jitter that occurs when a custom link is
hovered. Will be removed once the Blink library is fixed.

Also fix a missing parentheses.

Bug:  897006 
Change-Id: Idea7a921d1933845fb3ab00ecaf649161b21b114
Reviewed-on: https://chromium-review.googlesource.com/c/1295170
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602192}
[modify] https://crrev.com/c531d2d75306cee6da5c07120289352cc065f700/chrome/browser/resources/local_ntp/local_ntp.css
[modify] https://crrev.com/c531d2d75306cee6da5c07120289352cc065f700/chrome/browser/resources/local_ntp/most_visited_single.js

Just to update:

Above issue is not seen fixed on latest canary build #72.0.3591.0 using Windows(7,8,8.1,10),Mac(10.13.6,10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS) OS.

Please refer attached screen cast.

Thank you. 
Actual_Issue.mp4
490 KB View Download
Owner: kristip...@chromium.org
Status: Fixed (was: Assigned)
I filed  bug 898941  for the root cause. Closing this one as the UI issue has been worked around.
Labels: AddToRemoteNTP
This issue is still present in remote NTP, but has been fixed in local NTP. Please recheck with the "use-google-local-ntp" flag enabled.

I will update the bug once this issue has been fixed in remote and can be verified.
With respect to comment 11:

Above issue is fixed on latest canary build #72.0.3596.0 using Windows(7,8,8.1,10),Mac(10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS) OS.

Kindly refer attached video for the same.

Thank you.
Actual_Issue.mp4
256 KB View Download
The root cause of this bug has been fixed and should be working for remote NTP as well.
Please re-verify this once crrev.com/c/1310717 lands.
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e7bff9fef855b02e3ef4982ff5eb67fd819dc7c

commit 8e7bff9fef855b02e3ef4982ff5eb67fd819dc7c
Author: Kristi Park <kristipark@chromium.org>
Date: Wed Oct 31 22:11:57 2018

[NTP] Remove quick fix for 1px jitter

Root cause has been fixed in https://crbug/898941

Bug:  897006 
Change-Id: Ie1a6cbb60345c733fe088858870696dcc69a5683
Reviewed-on: https://chromium-review.googlesource.com/c/1310717
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604408}
[modify] https://crrev.com/8e7bff9fef855b02e3ef4982ff5eb67fd819dc7c/chrome/browser/resources/local_ntp/local_ntp.css

Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
Update:
Above issue is not seen fixed on latest canary build #72.0.3598.0 using Windows(7,8,8.1,10),Mac(10.13.6,10.13.1,10.13.6,10.14.1) and Linux(14.04 LTS) OS.

Please refer attached screen cast.

Thank you. 
Fix_Issue.mp4
382 KB View Download
Labels: -TE-Verified-M72 -TE-Verified-72.0.3598.0
c16: To clarify, is this verified as fixed?
Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
(Labels removed accidentally)
Labels: -AddToRemoteNTP -TE-Verified-M72 -TE-Verified-72.0.3598.0
Labels: TE-Verified-M72 TE-Verified-72.0.3598.0

Sign in to add a comment