New issue
Advanced search Search tips

Issue 896973 link

Starred by 1 user
Status: Fixed
Owner:
msw@chromium.org
Closed: Oct 24
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 896947



Sign in to add a comment

mash: Support TouchSelectionControllerClientAura

Project Member Reported by msw@chromium.org, Oct 19 
mash: Support TouchSelectionControllerClientAura

This class observes system-wide events from Chrome using an Env pre-target handler.
That's not supported in SingleProcessMash, it should be converted to ui::EventObserver like TouchSelectionControllerImpl.

The purpose is to close touch selection handles and context menus on mouse events outside the window/parent.
https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc?rcl=a563e29ee53b9b2f5e8a35da7c52f96310636a02&l=75
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb5a6e01379d536540f967981f7eb04698a157a

commit acb5a6e01379d536540f967981f7eb04698a157a
Author: Mike Wasserman <msw@chromium.org>
Date: Tue Oct 23 20:58:13 2018

mash: Make TouchSelectionControllerClientAura use ui::EventObserver

Close touch selection ui in Mash on events outside the browser window.
(global pre-target handlers are not supported in window service clients)
This follows and refines the new pattern in TouchSelectionControllerImpl.

Bug:  896973 ,  884394 
Test: Text touch selection ui hides as expected in Views and Content.
Change-Id: Iedba63a7ce5d5f70f9763cf540d26ee69cee5f28
Reviewed-on: https://chromium-review.googlesource.com/c/1292274
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602084}
[modify] https://crrev.com/acb5a6e01379d536540f967981f7eb04698a157a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc
[modify] https://crrev.com/acb5a6e01379d536540f967981f7eb04698a157a/content/browser/renderer_host/input/touch_selection_controller_client_aura.h
[modify] https://crrev.com/acb5a6e01379d536540f967981f7eb04698a157a/ui/views/touchui/touch_selection_controller_impl.cc

Comment 2 by msw@chromium.org, Oct 24

Status: Fixed (was: Assigned)
►

Sign in to add a comment