mash: Support RenderWidgetHostViewAura::EventFilterForPopupExit |
|||
Issue descriptionmash: support RenderWidgetHostViewAura::EventFilterForPopupExit This class observes system-wide events from Chrome using an Env pre-target handler. That's not supported in SingleProcessMash, it should be converted to ui::EventObserver. The purpose is to close web popups on mouse/touch press outside the window/parent. https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_aura.cc?rcl=b0e3983f7a7a814c285c2302b16ffd345ba37815&l=203
,
Oct 19
I think this is for <select> dropdowns and similar:
// Perform all the initialization steps necessary for this object to represent
// a popup (such as a <select> dropdown), then shows the popup at |pos|.
virtual void InitAsPopup(RenderWidgetHostView* parent_host_view,
const gfx::Rect& bounds) = 0;
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/19c4174f7b35f90e744e724db84975ba4bce4e08 commit 19c4174f7b35f90e744e724db84975ba4bce4e08 Author: James Cook <jamescook@chromium.org> Date: Mon Oct 22 20:30:47 2018 Convert <select> popup observer to ui::EventObserver This is needed for it to observe clicks outside the browser window (e.g. on the desktop) under SingleProcessMash on Chrome OS. Bug: 896948 Test: existing content_unittests Change-Id: I8cdfa78f934255bde7e23a3964990e418717eb54 Reviewed-on: https://chromium-review.googlesource.com/c/1292810 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601710} [modify] https://crrev.com/19c4174f7b35f90e744e724db84975ba4bce4e08/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/19c4174f7b35f90e744e724db84975ba4bce4e08/content/browser/renderer_host/render_widget_host_view_aura.h
,
Oct 22
|
|||
►
Sign in to add a comment |
|||
Comment 1 by msw@chromium.org
, Oct 19Summary: mash: Support RenderWidgetHostViewAura::EventFilterForPopupExit (was: mash: support RenderWidgetHostViewAura::EventFilterForPopupExit)