M71 Beta promotion is coming VERY soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge into the release branch ASAP. Thank you.

M71 Beta promotion is coming VERY soon. Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and request a merge into the release branch latest by Monday, 10/22 morning. Thank you.

The CL is almost completed, and we're waiting for the privacy review and UKM database change.

https://chromium-review.googlesource.com/c/chromium/src/+/1289695

Thank you hongchan@.

Pls make sure CL is ready and safe to merge by Monday morning PT and request a merge then.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d95973e289887c5cf6082544adf72af309e230d

commit 2d95973e289887c5cf6082544adf72af309e230d
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Sun Oct 21 11:47:54 2018

Add UKM audibility timer in AudioContextManagerImpl

This CL implements the audibility timer for multiple AudioContexts
in AudioContextManagerImpl. The "started" event triggers the
tracking and the "stopped" event triggers the calculation of
elapsed time followed by UKM data record.

Bug:  896944 
Change-Id: Id1f635df4783247aca3656d07c02af907ffd72e4
Reviewed-on: https://chromium-review.googlesource.com/c/1289695
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601446}
[modify] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/content/browser/media/webaudio/audio_context_manager_browsertest.cc
[modify] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/content/browser/media/webaudio/audio_context_manager_impl.cc
[modify] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/content/browser/media/webaudio/audio_context_manager_impl.h
[add] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/content/browser/media/webaudio/audio_context_manager_impl_unittest.cc
[modify] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/content/test/BUILD.gn
[modify] https://crrev.com/2d95973e289887c5cf6082544adf72af309e230d/tools/metrics/ukm/ukm.xml

Pls update bug with canary result tomorrow morning and request a merge to M71 if change looks good in canary. Thank you.

The NextAction date has arrived: 2018-10-22

Seems like this change didn't make it to latest canary #72.0.3588.0 (branch_base_position: 601409) and we're cutting M71 Beta RC today, Can this wait until next week beta?

I would prefer to have it in this beta in order to have metrics early but we would need another CL to land it Beta too (crbug.com/897451). If we can have both merged in this beta, it would be great :)

Just to be clear, the other bug has its fix in trunk but like this one, it's not in Canary yet.

Thank you  mlamouri@ as both changes are not yet in canary yet, let's target for next week beta on Wednesday. So by then both changes will be baked in canary. Pls let me know ASAP if there is any concern here. 

The other change *needs* to be in Stable but that's a different question :)

The other change has landed in Beta. Could we get the merge re-evaluated?

Per offline chat with  mlamouri@, we will take this merge in for next week beta. Pls request a merge latest by this Friday. Thank you.

How is the change looking in canary? If it is looking good, pls request a merge to M71 ASAP. Thank you.

Here's a summary of the rules that were executed: 
 - OnlyMergeApprovedChange: Rule Failed -- Revision fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6 was merged to refs/branch-heads/3578 branch with no merge approval from a TPM! 
Please explain why this change was merged to the branch!
 - AcknowledgeMerge: Notification Required -- 

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6

Commit: fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6
Author: mlamouri@chromium.org
Commiter: mlamouri@chromium.org
Date: 2018-10-25 13:12:37 +0000 UTC

Add UKM audibility timer in AudioContextManagerImpl

This CL implements the audibility timer for multiple AudioContexts
in AudioContextManagerImpl. The "started" event triggers the
tracking and the "stopped" event triggers the calculation of
elapsed time followed by UKM data record.

Bug:  896944 
Change-Id: Id1f635df4783247aca3656d07c02af907ffd72e4
Reviewed-on: https://chromium-review.googlesource.com/c/1289695
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601446}(cherry picked from commit 2d95973e289887c5cf6082544adf72af309e230d)
Reviewed-on: https://chromium-review.googlesource.com/c/1298999
Cr-Commit-Position: refs/branch-heads/3578@{#316}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6

commit fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Thu Oct 25 13:12:37 2018

Add UKM audibility timer in AudioContextManagerImpl

This CL implements the audibility timer for multiple AudioContexts
in AudioContextManagerImpl. The "started" event triggers the
tracking and the "stopped" event triggers the calculation of
elapsed time followed by UKM data record.

Bug:  896944 
Change-Id: Id1f635df4783247aca3656d07c02af907ffd72e4
Reviewed-on: https://chromium-review.googlesource.com/c/1289695
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#601446}(cherry picked from commit 2d95973e289887c5cf6082544adf72af309e230d)
Reviewed-on: https://chromium-review.googlesource.com/c/1298999
Cr-Commit-Position: refs/branch-heads/3578@{#316}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/content/browser/media/webaudio/audio_context_manager_browsertest.cc
[modify] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/content/browser/media/webaudio/audio_context_manager_impl.cc
[modify] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/content/browser/media/webaudio/audio_context_manager_impl.h
[add] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/content/browser/media/webaudio/audio_context_manager_impl_unittest.cc
[modify] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/content/test/BUILD.gn
[modify] https://crrev.com/fe88cfdd2fbe0ee1572a649bc19cc682f572cbd6/tools/metrics/ukm/ukm.xml

Hi I just tested on Canary and it's working. Though, I misread and read "merge ASAP" instead of requesting the merge so I just merged :(

Thank you y mlamouri@. No problem approving merge now and removing "Merge-Without-Approval" label.

Still seeing 554 crashes from 504 clients so far on latest Stable - 71.0.3578.98 on Mac OS.

Updating the issue as the fix seems to be merged to 3578 in C#22. However, no crashes are observed in latest Beta, Dev and Canary builds.