New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 896932 link

Starred by 2 users
Status: Fixed
Owner:
zmo@chromium.org
Closed: Oct 22
Cc:
magchen@chromium.org
sunn...@chromium.org
vmi...@chromium.org
█ brian.sc...@intel.com
yang...@intel.com
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

Add a histogram for Intel GPU generations on Windows

Project Member Reported by zmo@chromium.org, Oct 18 
This is beneficial for hardware overlay support and NV12 support sanity check

In theory any Skylake+ devices should support hardware overlays and Kabylake+ devices should support hardware overlays with NV12 format.

However, that's not always the case. For example, on the following device, hardware overlay support is missing:

Device: Lenovo X1 Yoga V3 2018
OS: Windows 10.0.16299
GPU: UHD Graphics 620 (Kabylake)
Driver: 24.20.100.6170

It seems IDXGIOutput3::CheckOverlaySupport() returns pFlags=0 on all three formats (BGRA, YUY2, NV12).

So having a histogram of Intel GPU generation user percentage will help us understand what the gap is between "should supported" and "actually supported."

Comment 1 by zmo@chromium.org, Oct 18

Cc: brian.sc...@intel.com
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a995f181c7b47c13fc0618d681d1cc33a0e87a8

commit 3a995f181c7b47c13fc0618d681d1cc33a0e87a8
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Oct 22 22:53:44 2018

Add a histogram for Intel GPU generation.

BUG= 896932 
TEST=about:histograms
R=kbr@chromium.org,sunnyps@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I20db893a19ff93120ce40fded22eaa153546ac3b
Reviewed-on: https://chromium-review.googlesource.com/c/1290202
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601760}
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/content/browser/gpu/gpu_data_manager_testing_arrays_and_structs_autogen.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/content/browser/gpu/gpu_data_manager_testing_autogen.cc
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/content/browser/gpu/gpu_data_manager_testing_exceptions_autogen.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_control_list.cc
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_control_list.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_control_list_testing_arrays_and_structs_autogen.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_control_list_testing_autogen.cc
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_control_list_testing_exceptions_autogen.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_info.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_util.cc
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/gpu_util.h
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/config/process_json.py
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/gpu/ipc/service/gpu_init.cc
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3a995f181c7b47c13fc0618d681d1cc33a0e87a8/tools/metrics/histograms/histograms.xml

Comment 3 by zmo@chromium.org, Oct 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment