"Quick lookup" in new tab doesn't work |
|||
Issue descriptionAccording to comments in TabStripModel::AddWebContents, we supposedly support the user doing a "quick lookup": opening a new tab (via Ctrl-T or the new tab button), making one omnibox navigation (probably a search), and then upon closing the tab we will jump back to the tab they started on. This currently only works without the intervening navigation (so if they open and then immediately close a new tab, we jump back correctly). There's a comment in TabNavigating that indicates we try to prevent the first navigation from clearing the "opener" field, but apparently this doesn't work.
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e78b9a129064c9f459286da5a187fb182a80a751 commit e78b9a129064c9f459286da5a187fb182a80a751 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Oct 23 00:49:13 2018 Fix TabStripModel::IsNewTabAtEndOfTabStrip never returning true. TabStripModel::IsNewTabAtEndOfTabStrip is called during a tab navigation and is intended to prevent the opener relationship of that tab from being forgotten if it returns true. However, GetURL was changed to return the visible URL (i.e. the one being loaded) instead of the last committed URL, so this would always fail. Also updates the associated test, which was not doing a navigation. Bug: 896929 Change-Id: I3f00e3f6f84da2986bab96b85aeb5eb04ef3cb21 Reviewed-on: https://chromium-review.googlesource.com/c/1292003 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601808} [modify] https://crrev.com/e78b9a129064c9f459286da5a187fb182a80a751/chrome/browser/ui/tabs/tab_strip_model.cc [modify] https://crrev.com/e78b9a129064c9f459286da5a187fb182a80a751/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
,
Oct 23
,
Jan 11
Issue 920829 has been merged into this issue. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bsep@chromium.org
, Oct 19