Add UMA to new Previews UI |
||||||||
Issue descriptionSomething like "OmniboxAction" with previews type suffixes
,
Oct 25
Want to merge in this UMA to M71 for a feature launch in 71. Thanks!
,
Oct 25
This bug requires manual review: M71 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 26
ping on merge request
,
Oct 26
Merge approved to 71, branch 3578.
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65ec5f48b3c4361c37602cb6af76620c75932ef0 Commit: 65ec5f48b3c4361c37602cb6af76620c75932ef0 Author: robertogden@chromium.org Commiter: tbansal@chromium.org Date: 2018-10-26 22:27:54 +0000 UTC Add UMA collection to Previews Omnibox UI Adds a new histogram "Previews.OmniboxAction" with suffixes for each previews type. Enum buckets are the different actions that can take place. Bug: 896921 Change-Id: I2578a297247ad9ac75a7b14c07dbdf053c7eb048 Reviewed-on: https://chromium-review.googlesource.com/c/1289959 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Megan Jablonski <megjablon@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602582}(cherry picked from commit 2a9a6167fc9a70a2b3b1fa736d53de74250cbb0c) Reviewed-on: https://chromium-review.googlesource.com/c/1302855 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#356} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65ec5f48b3c4361c37602cb6af76620c75932ef0 commit 65ec5f48b3c4361c37602cb6af76620c75932ef0 Author: Robert Ogden <robertogden@chromium.org> Date: Fri Oct 26 22:27:54 2018 Add UMA collection to Previews Omnibox UI Adds a new histogram "Previews.OmniboxAction" with suffixes for each previews type. Enum buckets are the different actions that can take place. Bug: 896921 Change-Id: I2578a297247ad9ac75a7b14c07dbdf053c7eb048 Reviewed-on: https://chromium-review.googlesource.com/c/1289959 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Megan Jablonski <megjablon@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602582}(cherry picked from commit 2a9a6167fc9a70a2b3b1fa736d53de74250cbb0c) Reviewed-on: https://chromium-review.googlesource.com/c/1302855 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#356} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoController.java [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/android/java/src/org/chromium/chrome/browser/previews/PreviewsAndroidBridge.java [add] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/android/java/src/org/chromium/chrome/browser/previews/PreviewsUma.java [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/android/java_sources.gni [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/browser/previews/android/previews_android_bridge.cc [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/chrome/browser/previews/android/previews_android_bridge.h [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/tools/metrics/histograms/enums.xml [modify] https://crrev.com/65ec5f48b3c4361c37602cb6af76620c75932ef0/tools/metrics/histograms/histograms.xml
,
Oct 27
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Oct 25