Issue metadata
Sign in to add a comment
|
TTS uses a UK voice on en-US |
||||||||||||||||||||||||
Issue description- start Chrome OS on linux - toggle ChromeVox on (assuming all tts bits are also in their expected places) result: UK voice starts speaking expected: en-US voice speaks. Notes: The UK voice is actually a downloadable voice. What's happening is that the voices declared in the manifest are being used when ChromeVox queries for voices. This is timing related because the voices that are *actually* available need to be sent by the tts extension. However, it comes after (at times) the query from ChromeVox arrives. The UK voice is selected by tts controller and we end up with a request for it in the engine. Finally, the engine downloads the voice. bad This started occurring in full once ChromeVox started respecting the system voice (and didn't set a lang) when making tts speak calls.
,
Oct 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/353a575d06548f9f2db3edd7a70c81ddc04c9a37 commit 353a575d06548f9f2db3edd7a70c81ddc04c9a37 Author: David Tseng <dtseng@chromium.org> Date: Sat Oct 20 02:45:15 2018 Fix exact system language to tts language matching Bug: 896910 Change-Id: I7b8b08147943a214900e6b835ce7c45016167b22 Reviewed-on: https://chromium-review.googlesource.com/c/1292151 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#601393} [modify] https://crrev.com/353a575d06548f9f2db3edd7a70c81ddc04c9a37/chrome/browser/speech/tts_controller_impl.cc [modify] https://crrev.com/353a575d06548f9f2db3edd7a70c81ddc04c9a37/chrome/browser/speech/tts_controller_unittest.cc
,
Nov 28
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dmazz...@chromium.org
, Oct 19